Handler 続き

[H1rono]

#231 から

• ドキュメント
• Handlerのテスト書く #242

[H1rono]

handler modがprivateでも問題ないことに気づいちゃった
やらない、docsを公開するため

[H1rono]

✅ ここのcloneはself.serviceに対してだけでいい

traq-bot-http-rs/src/handler.rs

Lines 213 to 215 in 3d86c51

	let mut s = self.clone();
	// https://docs.rs/tower/latest/tower/trait.Service.html#be-careful-when-cloning-inner-services
	std::mem::swap(self, &mut s);

[H1rono]

✅ packages.metadata.docs.rs更新しないと docs.rs で見えない

traq-bot-http-rs/Cargo.toml

Line 22 in 3d86c51

features = ["http"]

[H1rono]

✅ READMEにtowerfeatureのこと書いてない

[H1rono]

✅ EventWithState消せる

[H1rono]

✅ <WithState as Service>::poll_readyの実装ミス

traq-bot-http-rs/src/handler.rs

Lines 109 to 110 in 3d86c51

	fn poll_ready(&mut self, _cx: &mut Context<'_>) -> Poll<Result<(), Self::Error>> {
	Poll::Ready(Ok(()))

traq-bot-http-rs/src/handler.rs

Lines 131 to 132 in 3d86c51

	fn poll_ready(&mut self, _cx: &mut Context<'_>) -> Poll<Result<(), Self::Error>> {
	Poll::Ready(Ok(()))

self.service.poll_ready(cx)をtransparentさせる必要がある

[H1rono]

traq-bot-http-rs/src/macros.rs

Lines 466 to 469 in 3d86c51

	impl<Service, Fallback> ::tower::Service<$crate::Event>
	for [< $e:camel Service >] <Service, Fallback, $crate::payloads::[< $e:camel Payload >] >
	where
	Service: ::tower::Service<$crate::payloads::[< $e:camel Payload >], Response = ()>,

これに対応した1-tupleの実装 やらない

        impl<Service, Fallback> ::tower::Service<$crate::Event>
        for [< $e:camel Service >] <Service, Fallback, $crate::payloads::[< $e:camel Payload >] >
        where
            Service: ::tower::Service<($crate::payloads::[< $e:camel Payload >],), Response = ()>, ...

[H1rono]

Handler::boxed_inner(self)
-> Handler<BoxCloneService<Event, (), Error>>;

[H1rono]

Handler::check_cloneとかあると嬉しそう
https://docs.rs/tower/0.5.1/tower/builder/struct.ServiceBuilder.html#method.check_clone

[H1rono]

✅ Srv: Service<..., Error = crate::Error>にできる

traq-bot-http-rs/src/handler.rs

Lines 300 to 302 in b83191d

	Srv: Service<Event, Response = ()> + Send + 'static,
	Srv: Clone,
	Srv::Error: Into<Box<dyn std::error::Error + Send + Sync + 'static>>,

が、これを入れるとHandler::newが厳しくなる

[H1rono]

✅ {EventKind}Serviceの型名をOn{EventKind}にrenameしたい(API Guidelinesで見かけた気がしたけどなかった、よく見るライブラリのnaming conventionに従うとこうなる)