Skip to content

Commit d3bc563

Browse files
committed
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2 parents 941a979 + fbcc532 commit d3bc563

File tree

10 files changed

+472
-1633
lines changed

10 files changed

+472
-1633
lines changed

CMakeLists.txt

+3-1
Original file line numberDiff line numberDiff line change
@@ -1047,7 +1047,9 @@ endif()
10471047
if(CMAKE_GENERATOR MATCHES Xcode)
10481048
status(" Xcode:" ${XCODE_VERSION})
10491049
endif()
1050-
if(NOT CMAKE_GENERATOR MATCHES "Xcode|Visual Studio")
1050+
if(CMAKE_GENERATOR MATCHES "Xcode|Visual Studio|Multi-Config")
1051+
status(" Configuration:" ${CMAKE_CONFIGURATION_TYPES})
1052+
else()
10511053
status(" Configuration:" ${CMAKE_BUILD_TYPE})
10521054
endif()
10531055

README.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
* Homepage: <https://opencv.org>
66
* Courses: <https://opencv.org/courses>
77
* Docs: <https://docs.opencv.org/master/>
8-
* Q&A forum: <http://answers.opencv.org>
8+
* Q&A forum: <https://forum.opencv.org>
9+
* previous forum (read only): <http://answers.opencv.org>
910
* Issue tracking: <https://github.com/opencv/opencv/issues>
1011
* Additional OpenCV functionality: <https://github.com/opencv/opencv_contrib>
1112

doc/js_tutorials/js_assets/js_template_matching_matchTemplate.html

+2-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,8 @@ <h2>Template Match Example</h2>
7474
utils.loadCode('codeSnippet', 'codeEditor');
7575
utils.loadImageToCanvas('lena.jpg', 'imageCanvasInput');
7676
utils.loadImageToCanvas('lenaFace.png', 'templateCanvasInput');
77-
utils.addFileInputHandler('fileInput', 'canvasInput');
77+
utils.addFileInputHandler('fileInput', 'imageCanvasInput');
78+
utils.addFileInputHandler('templateFileInput', 'templateCanvasInput');
7879

7980
let tryIt = document.getElementById('tryIt');
8081
tryIt.addEventListener('click', () => {

doc/js_tutorials/js_setup/js_usage/js_usage.markdown

+1-1
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ In this tutorial, we just show a cv.Mat on screen. To show a cv.Mat, you need a
8282

8383
You can use cv.imshow to show cv.Mat on the canvas.
8484
@code{.js}
85-
cv.imshow(mat, "outputCanvas");
85+
cv.imshow("outputCanvas", mat);
8686
@endcode
8787

8888
Putting all of the steps together, the final index.html is shown below.

doc/py_tutorials/py_feature2d/py_sift_intro/py_sift_intro.markdown

+9-8
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ scale invariant.
2020

2121
![image](images/sift_scale_invariant.jpg)
2222

23-
So, in 2004, **D.Lowe**, University of British Columbia, came up with a new algorithm, Scale
23+
In 2004, **D.Lowe**, University of British Columbia, came up with a new algorithm, Scale
2424
Invariant Feature Transform (SIFT) in his paper, **Distinctive Image Features from Scale-Invariant
2525
Keypoints**, which extract keypoints and compute its descriptors. *(This paper is easy to understand
26-
and considered to be best material available on SIFT. So this explanation is just a short summary of
26+
and considered to be best material available on SIFT. This explanation is just a short summary of
2727
this paper)*.
2828

2929
There are mainly four steps involved in SIFT algorithm. We will see them one-by-one.
@@ -102,16 +102,17 @@ reasons. In that case, ratio of closest-distance to second-closest distance is t
102102
greater than 0.8, they are rejected. It eliminates around 90% of false matches while discards only
103103
5% correct matches, as per the paper.
104104

105-
So this is a summary of SIFT algorithm. For more details and understanding, reading the original
106-
paper is highly recommended. Remember one thing, this algorithm is patented. So this algorithm is
107-
included in [the opencv contrib repo](https://github.com/opencv/opencv_contrib)
105+
This is a summary of SIFT algorithm. For more details and understanding, reading the original
106+
paper is highly recommended.
108107

109108
SIFT in OpenCV
110109
--------------
111110

112-
So now let's see SIFT functionalities available in OpenCV. Let's start with keypoint detection and
113-
draw them. First we have to construct a SIFT object. We can pass different parameters to it which
114-
are optional and they are well explained in docs.
111+
Now let's see SIFT functionalities available in OpenCV. Note that these were previously only
112+
available in [the opencv contrib repo](https://github.com/opencv/opencv_contrib), but the patent
113+
expired in the year 2020. So they are now included in the main repo. Let's start with keypoint
114+
detection and draw them. First we have to construct a SIFT object. We can pass different
115+
parameters to it which are optional and they are well explained in docs.
115116
@code{.py}
116117
import numpy as np
117118
import cv2 as cv

doc/tutorials/imgproc/imgtrans/hough_lines/hough_lines.markdown

+1-1
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ First you apply the transform:
224224
- *theta*: The resolution of the parameter \f$\theta\f$ in radians. We use **1 degree**
225225
(CV_PI/180)
226226
- *threshold*: The minimum number of intersections to "*detect*" a line
227-
- *minLinLength*: The minimum number of points that can form a line. Lines with less than
227+
- *minLineLength*: The minimum number of points that can form a line. Lines with less than
228228
this number of points are disregarded.
229229
- *maxLineGap*: The maximum gap between two points to be considered in the same line.
230230

0 commit comments

Comments
 (0)