Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the datatype of the properties in the NonPerformingLoan.jsonld #33

Open
Purvanshsingh opened this issue Aug 19, 2021 · 2 comments
Open

Comments

@Purvanshsingh
Copy link
Member

Properties should have a proper datatype in nplo.jsonld so that they can be parsed by nplvocab_parse.py and converted into hydra properties with appropriate range.

Currently, some properties in nplo.jsonld have some malicious property type in this format :

Screenshot from 2021-08-19 23-12-56

Due to which the property types are generated in an inappropriate format.
Screenshot from 2021-08-19 23-04-57

object uri :

http://34.145.188.116:8080/creditrisk_api/PrivateBorrower/d936990b-24e6-43b7-9a1f-e5a1d22e42f8

It should be refactored to this format :

{
   "rdfs:range": {
        "@id": "xsd:decimal"
       }
}

@open-risk
Copy link
Contributor

I would probably say "malformed" properties rather than "malicious" because the meaning is quite different :-)

@Krish-bhardwaj
Copy link

Hi i am new to open source contribution can you guide me how to solve this issue and assign me this issue @Purvanshsingh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants