Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate testsuite from unittest to pytest #460

Closed
1 of 2 tasks
sameshl opened this issue Mar 17, 2020 · 5 comments
Closed
1 of 2 tasks

Migrate testsuite from unittest to pytest #460

sameshl opened this issue Mar 17, 2020 · 5 comments

Comments

@sameshl
Copy link
Member

sameshl commented Mar 17, 2020

I'm submitting a

  • bug report.
  • feature request.

Current Behaviour:

The testsuite for hydrus is written using unittest library.

Expected Behaviour:

@xadahiya I feel that using pytest would greatly improve the readability of the test code with its features like fixtures, parameterisation, etc. As hydrus continues to develop and we continue to refactor it, I think this is an important point we might want to consider. The only disadvantage I feel using pytest is that it is not in the standard library.

Steps to reproduce:

Do you want to work on this issue?

Yes

@xadahiya
Copy link
Member

Sounds good! Please create a Pr

@Mec-iS
Copy link
Contributor

Mec-iS commented Mar 18, 2020

I think it is a good improvement, it may speed up the automated test pipeline and allow more insight in the codebase for the purpose of a better proposal.

@sameshl
Copy link
Member Author

sameshl commented Mar 18, 2020

@Mec-iS Yes you are right. I have already started working on it.

@Mec-iS
Copy link
Contributor

Mec-iS commented Apr 29, 2020

please confirm that the number of tests executed by Travis in #466 are the same as in the old test machinery

@sameshl
Copy link
Member Author

sameshl commented Apr 29, 2020

@Mec-iS Yes, I can confirm that the number of tests executed by Travis in #466 is same as the old test machinery. I am attaching some screenshots of the relevant parts of the build section so it becomes easier for you to see.

The first image is a screenshot of the travis CI build in #466 , it shows that the number of tests run(passed) are 54:
image

The second image is a screenshot of the travis CI build in #456, this one also shows that the number of tests run are 54:
image

Therefore, the number of tests executed by Travis is same in #466 as the old test machinery(54).

@xadahiya xadahiya closed this as completed May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants