You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The function above issues a rollback without logging. Rolling back operations are importanto to highlight for maintance reason, so it should look like:
try:
session.commit()
except InvalidRequestError as e:
session.rollback()
logging.warning("Rollback in [function name] because of {str(e)}")
[raise 400]?
return collection_id
It would be nice to take this opportunity to implement structured logging with structlog
The text was updated successfully, but these errors were encountered:
I'm submitting a
Current Behaviour:
Logging is only present in
app.py
.Logging is seldommly used. For example in the case of
delete_collection_member
:Expected Behaviour:
The function above issues a rollback without logging. Rolling back operations are importanto to highlight for maintance reason, so it should look like:
It would be nice to take this opportunity to implement structured logging with
structlog
The text was updated successfully, but these errors were encountered: