From 8897fbe3cdc5e8bd624ca2376cffee48596e8176 Mon Sep 17 00:00:00 2001 From: Barry Pollard Date: Thu, 22 Feb 2024 15:35:34 +0000 Subject: [PATCH 1/3] Reduce best practive score (#3582) --- .github/lighthouse/lighthouse-config-prod.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/lighthouse/lighthouse-config-prod.json b/.github/lighthouse/lighthouse-config-prod.json index b5657941b61..8ab301f7ee5 100644 --- a/.github/lighthouse/lighthouse-config-prod.json +++ b/.github/lighthouse/lighthouse-config-prod.json @@ -4,7 +4,7 @@ "preset": "lighthouse:recommended", "assertions": { "categories:accessibility": ["error", {"minScore": 1}], - "categories:best-practices": ["error", {"minScore": 0.92}], + "categories:best-practices": ["error", {"minScore": 0.78}], "categories:seo": ["error", {"minScore": 1}], "bf-cache": "off", "bootup-time": "off", From cf46305e20044a7dc7e4de41f6a91a2f1c15c4cd Mon Sep 17 00:00:00 2001 From: Barry Pollard Date: Fri, 23 Feb 2024 21:16:44 +0000 Subject: [PATCH 2/3] Remove desiredExecitionStart (#3583) --- src/static/js/send-web-vitals.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/static/js/send-web-vitals.js b/src/static/js/send-web-vitals.js index 85708847e71..e11526d45b0 100644 --- a/src/static/js/send-web-vitals.js +++ b/src/static/js/send-web-vitals.js @@ -24,7 +24,7 @@ function sendWebVitals() { return entry.startTime < (loaf.startTime + loaf.duration) && loaf.startTime < (entry.startTime + entry.duration); }).forEach(loaf => { loaf.scripts.forEach(script => { - const totalDuration = script.startTime + script.duration - script.desiredExecutionStart; + const totalDuration = script.startTime + script.duration; if (totalDuration > loafAttribution.debug_loaf_script_total_duration) { loafAttribution = { // Stats for the LoAF entry itself. From cf762cb2b699141ae8bd99620250e7a1d05e1191 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Fri, 23 Feb 2024 21:50:48 +0000 Subject: [PATCH 3/3] Update Timestamps (#3584) Co-authored-by: tunetheweb <10931297+tunetheweb@users.noreply.github.com> --- src/config/last_updated.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/config/last_updated.json b/src/config/last_updated.json index 87ba3e25588..0bb48aef3a2 100644 --- a/src/config/last_updated.json +++ b/src/config/last_updated.json @@ -36,8 +36,8 @@ }, "/static/js/send-web-vitals.js": { "date_published": "2021-02-24T00:00:00.000Z", - "date_modified": "2024-02-08T00:00:00.000Z", - "hash": "63611e8cc5b4e52b4d3d65866dbade27" + "date_modified": "2024-02-23T00:00:00.000Z", + "hash": "dbdf76e48652c343c8d368cf130f7928" }, "/static/js/web-vitals.js": { "date_published": "2020-11-13T00:00:00.000Z",