Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pages and requests schemas on staging to match crawl dataset #18

Closed
max-ostapenko opened this issue Oct 14, 2024 · 7 comments · Fixed by #28
Closed

Update pages and requests schemas on staging to match crawl dataset #18

max-ostapenko opened this issue Oct 14, 2024 · 7 comments · Fixed by #28

Comments

@max-ostapenko
Copy link

max-ostapenko commented Oct 14, 2024

The older data schema is being reprocessed using these queries:

After we promote these new schemas to be the new default we need to update agent processing.

We should be able to just do SELECT * when copying data from crawl_staging to crawl in crawl_complete pipeline.

@max-ostapenko max-ostapenko changed the title Align agent data structure to be written to BQ with the new all dataset schema. Update pages and requests schemas written by agent to BQ to a new one Oct 14, 2024
@max-ostapenko
Copy link
Author

The transformation of crawl_staging.requests into crawl.requests lasted ~13h for Nov 2024 crawl (not including failed attempts).

@pmeenan let's update the wptagent to match crawl_staging with crawl schema.
As agreed we will not update legacy table anymore, so ready for a cleanup.

@max-ostapenko
Copy link
Author

HTTPArchive/dataform#33 to sync the pipeline with the adjustments.

@max-ostapenko max-ostapenko changed the title Update pages and requests schemas written by agent to BQ to a new one Update pages and requests schemas on staging to match crawl dataset Dec 3, 2024
@max-ostapenko
Copy link
Author

I hope it's not gonna be needed, BUT in case there are some issues with ingesting data to JSON columns we can fallback to parsing STRING data within the pipeline as we do currently.

@max-ostapenko
Copy link
Author

@pmeenan from data in crawl_staging it looks like pages.summary values are not yet trimmed, e.g.:

  • '$._adult_site',
  • '$.archive',
  • '$.avg_dom_depth',
  • '$.crawlid',
  • '$.createDate',
  • '$.doctype',
  • '$.document_height',
  • '$.document_width',
  • '$.label',
  • '$.localstorage_size',
  • '$.meta_viewport',
  • '$.metadata',
  • '$.num_iframes',
  • '$.num_scripts_async',
  • '$.num_scripts_sync',
  • '$.num_scripts',
  • '$.pageid',
  • '$.PageSpeed',
  • '$.rank',
  • '$.sessionstorage_size',
  • '$.startedDateTime',
  • '$.url',
  • '$.urlhash',
  • '$.urlShort',
  • '$.usertiming',
  • '$.wptid',
  • '$.wptrun'

and pages.metadata:

  • '$.page_id',
  • '$.parent_page_id',
  • '$.root_page_id'

True, or are these rows outdated?

@max-ostapenko
Copy link
Author

Some of these fields were removed in #15.
How should we proceed?

@pmeenan
Copy link
Member

pmeenan commented Dec 6, 2024 via email

@max-ostapenko
Copy link
Author

Yeah, if sorted by payload.startedDateTime last two are OK.
👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants