Don't show boss damage being applied if you aren't on a boss quest

[saraolson]

if im on a collection quest and i complete a task, it shows damage being accumulated in the toast after i complete each task. it should only show this if im on a boss quest.

[tjb]

ill take a look!

[tjb]

@saraolson is there an easy way to test this and reproduce it multiple times? any easy collection quests i can test with?

[saraolson]

@tjb sorry, missed this notification! i usually use the 'attack of the mundane' quest and just cancel it before i finish to test. new accounts get it at level 15.

[tjb]

ok ty! i will test next week and see if I can reproduce!

[tjb]

@saraolson i just purchased the first part of the 'attach of the mundane' quest, i started it and aborted it and i did not see any message. can you attach a video of how you start the quest? perhaps i am doing things wrong

[saraolson]

@tjb the problematic toast is only seen when you check off a task. so if you're on a collection quest, check a task and you'll see the toast includes a number by a sword icon. that indicates boss damage, but boss damage isnt relevant when you're on a collection quest.

(the note about quitting the quest before completing it is just so you dont lose the scroll while testing)

[tjb]

Ah ok cool this is super helpful thank you so much @saraolson. i believe i just misunderstood the ticket cause i always assumed the sword meant my characters damage increased and that is not the case!

i should have some free time this weekend/into next week to get a fix together!

Example: I do not have a quest started and I still see the sword icon after completing a task and i should not, correct?

[tjb]

perhaps a domain question but why do we use progressDelta as damage? is there some documentation around the definition of the models that could give more insight?

additionally i am not on a question and i am getting progressDelta off of TaskResponseTempProtocol. should this only be present if i am on a quest with my party?

unsure if this is a question for @phillipthelen or @saraolson

[saraolson]

@tjb so we always want ppl to build quest 'progress' in the background because we will apply it if they start a quest later that day. we just dont want to show it if its not relevant.

does that help?

[tjb]

apologies i have been away but i am back :) i will pick this up this weekend unless someone else has resolved.

[tjb]

after refreshing my memory on this topic and digging into the code more the crux of the issue is that with TaskRepositoryImpl#score, which is make the toast occur, we do not know what type of quest the `progressDelta is coming from.

TaskResponseTempProtocol is the serialized return object from ScoreTaskCall. I took a look into our Realm models, user repository, etc and i could not find a correlation between the user and what quest they are on to get Quest object to then pass that information down into TaskRepositoryImpl#score if it is a boss or collection quest.

I think dug into the serialized response and into the API call. I believe what could fix is issue is a modification to the API response. if we could add a property called type to TaskResponseQuestProtocol and have the API add this information into the response, we would be able to tell what type of question is in our ScoreTaskCall response and then add the appropriate logic to show the sword in the toast or not.

@phillipthelen please let me know if i went in the wrong direction or if there is a repository in the iOS app that will allow me to plug in a user id to get the quest they are on as i could not find any.

if my proposed path of modifying the API is the path we want to do down, how would we do that? just make a API in the website repo for the score function?