Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for head dimension 128 #26

Open
perklet opened this issue May 16, 2024 · 4 comments
Open

Add support for head dimension 128 #26

perklet opened this issue May 16, 2024 · 4 comments

Comments

@perklet
Copy link

perklet commented May 16, 2024

Most recent models use hdim=128, it would be great to see that ThunderKittens also support that.

# assert training does not support head dim 128 yet
assert q.shape[2] == 64, "TK train currently supports head dim 64 only"

@benjaminfspector
Copy link
Collaborator

That is on the eventual to-do list!

@perklet
Copy link
Author

perklet commented May 16, 2024 via email

@benjaminfspector
Copy link
Collaborator

looping in @Aaryan0404 for this

@dz1iang
Copy link

dz1iang commented May 21, 2024

Could you please explain why there is a limitation on the size of the head dimension? I'm not very clear about it.

That is on the eventual to-do list!

Could you please explain why there is a limitation on the size of the head dimension? I'm not very clear about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants