Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent data models for bbox #87

Open
HiromuHota opened this issue Oct 9, 2020 · 0 comments
Open

Inconsistent data models for bbox #87

HiromuHota opened this issue Oct 9, 2020 · 0 comments
Assignees

Comments

@HiromuHota
Copy link
Contributor

Describe the bug

Data models that represent bounding boxes are inconsistent, which considerably degrades readability.
For example,

bbox: List[float] in the order of (y0, x0, y1, x1) at

f"bbox {int(box[1])} {int(box[0])} {int(box[3])} {int(box[2])}",

bbox: Tuple[float] in the order of (x0, y0, x1, y1) at

" ".join(["bbox"] + [str(int(_)) for _ in elem.bbox]),

word[1:]: List[float] in the order of (y0, x0, y1, x1) at

words = self.get_word_boundaries(elem)
for word in words:
top = int(word[1])
left = int(word[2])
bottom = int(word[3])
right = int(word[4])

To Reproduce

N/A

Expected behavior

I expect that they are consistent.

Error Logs/Screenshots

N/A

Environment (please complete the following information):

Additional context
Add any other context about the problem here.

See discussions at #84 (comment)

@HiromuHota HiromuHota self-assigned this Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant