Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop automatically downloading dxvk #4221

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Stop automatically downloading dxvk #4221

merged 1 commit into from
Dec 31, 2024

Conversation

Etaash-mathamsetty
Copy link
Member

It's not needed for people purely using proton, so avoid installing it for everyone.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@Etaash-mathamsetty Etaash-mathamsetty changed the title Stop automatically installing dxvk Stop automatically downloading dxvk Dec 30, 2024
arielj
arielj reviewed Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

this means it's not downloaded at boot but it will be downloaded when needed the first time, right?

@Etaash-mathamsetty
Copy link
Member Author

looks good to me

this means it's not downloaded at boot but it will be downloaded when needed the first time, right?

yes, for some people it doesn't download and then gives an annoying popup, so this would remove it

@Etaash-mathamsetty Etaash-mathamsetty merged commit b534c07 into main Dec 31, 2024
9 checks passed
@Etaash-mathamsetty Etaash-mathamsetty deleted the fix/dont-autoinstall-dxvk branch December 31, 2024 16:53
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arielj arielj arielj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Etaash-mathamsetty @arielj