Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to bs.obj #4

Open
mlms13 opened this issue Dec 12, 2019 · 0 comments
Open

Switch to bs.obj #4

mlms13 opened this issue Dec 12, 2019 · 0 comments

Comments

@mlms13
Copy link
Contributor

mlms13 commented Dec 12, 2019

We probably can't immediately take advantage of Bucklescript v7's records-as-js-objects since so many of the Mapbox objects expect fields to be missing (instead of undefined values), but we could consider switching from [@bs.deriving abstract] to a bs.obj implementation.

This has the advantage of being slightly more straightforward to read than the magical derived functions that come from @bs.deriving abstract, plus for simply constructing objects, we don't actually need any of the generated getter functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant