Console error after setting the include config to src/**/*.{graphql,gql}

[tschortsch]

Describe the bug

We set the include config in the houdini.config.js to src/**/*.{graphql,gql} so that Houdini doesn't watch all JS/TS files all the time (which led to a full reload of the page as soon anything changed). But now we're getting the following error in the console even if we don't have queries in our +page or +layout files:

⚠️ You are using at least one page/layout query but aren't "include"ing .js files in your config. \n This will cause houdini to not pick up the generated files and prevent it from working as expected.

Could it be that the condition for outputting this warning is not correctly defined:

houdini/packages/houdini-svelte/src/plugin/codegen/routes/index.ts

Lines 71 to 79 in c307841

	if (
	// Include path doesn't include js
	!config.include.some((path) => path.includes('js')) &&
	// And the plugin isn't configured to run in static mode
	(!plugin_config(config).static ||
	// User uses layout/page queries
	uniquePageQueries.length > 0 ||
	uniqueLayoutQueries.length > 0)
	) {

In my opinion the condition should look like this:

if (
	// Include path doesn't include js
	!config.include.some((path) => path.includes('js')) &&
	// And the plugin isn't configured to run in static mode
	(!plugin_config(config).static &&
	    // User uses layout/page queries
	    (uniquePageQueries.length > 0 ||
	    uniqueLayoutQueries.length > 0))
) {

Reproduction

No response

[AlecAivazis]

Houdini plays by vite plugin rules which means that it won't process files that don't match its include. This includes the fake files that are generated by having +page.gql files. To pull off what you want, your best bet is to ensure that +page and +layout files are included in your glob.

[tschortsch]

Thanks for the answer. But then I don't really get the error message or the variable names. Because it's saying that You are using at least one page/layout query but we don't really have those in our code and the uniquePageQueries and uniqueLayoutQueries are both empty objects. Maybe I'm missing something 🙈

[AlecAivazis]

Ah, i misread the original report - sorry about that! Looking with clearer eyes now and I think you're right. I'll reopen the issue and will look out for a PR so we can quickly merge/deploy the fix for you

[tschortsch]

Thanks a lot! If it helps I can create a PR for you. I'm just not sure if I can test it in detail.