New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider markup on search results page #1019

Open

tillprochaska opened this issue Aug 24, 2024 · 0 comments

Labels

a11y

Collaborator

tillprochaska commented Aug 24, 2024

Without a search query, we currently generate the following markup:

h1: All votes
- h2: Jul 17th, 2024
- h2: Vote title
- h2: Apr 25th, 2024
- h2: Vote title
- h2: Vote title
- …

We should probably either use:

h1: All votes
- h2: Jul 17th, 2024
  - h3: Vote title
- h2: Apr 25th, 2024
  - h3: Vote title
  - h3: Vote title
  - …

But given that there’s barely any content following after the headings, maybe a simple list of links is more appropriate:

h1: All votes
- h2: Jul 17th, 2024
  - ul
    - li: Vote title
- h2: Apr 25th, 2024
  - ul
    - li: Vote title
    - li: Vote title
    - …

tillprochaska added the a11y label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment