Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quoted or unquoted arguments for functions? #43

Open
foresthayes opened this issue May 26, 2019 · 1 comment
Open

Quoted or unquoted arguments for functions? #43

foresthayes opened this issue May 26, 2019 · 1 comment
Labels
question Further information is requested

Comments

@foresthayes
Copy link
Collaborator

I think this topic merits further discussion.

In principle I like the idea of unquoted arguments, however it seems to add a substantial amount of code to every function and greatly increases complexity in some cases. As we are increasing the scope of the package is this something worth continuing? For my part I am still struggling to predict how/when quosures will work and having difficulty getting them to work in more complex functions.

If we do keep with unquoted arguments, would it be possible to create an internal function that does much of heavy lifting as opposed to repeating code in each function?

@foresthayes foresthayes added the question Further information is requested label May 26, 2019
@Huh
Copy link
Owner

Huh commented May 26, 2019

I will look at the latest rlang documentation to see if there is any guidance or anything related to your question. I agree it is a bit onerous, but if I don't have to hit " twice for every argument I will be a happier user and when using dplyr I hate switching back and forth trying to remember what packages use it and which don't. I will search through some packages and see if I can't come up with some nice structures.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants