Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client update required #221

Open
surajsub opened this issue May 30, 2020 · 4 comments
Open

Client update required #221

surajsub opened this issue May 30, 2020 · 4 comments

Comments

@surajsub
Copy link

When a resource instance for hpvs is required to be created via terraform it need a sshkey to be passed in . The current client structure does not permit that
CreateServiceInstanceRequest struct {
Name string json:"name"
ServicePlanID string json:"resource_plan_id"
ResourceGroupID string json:"resource_group_id"
Crn string json:"crn,omitempty"
Tags []string json:"tags,omitempty"
Parameters map[string]interface{} json:"parameters,omitempty"
TargetCrn string json:"target_crn"
}
If we are to create the hpvs via terraform this structure needs to be update to add the SSHKey as well.

@hkantare
Copy link
Collaborator

hkantare commented Jun 4, 2020

Can you let me know how you provision the same service using the ibmcloud resource cli command..I think the ssh key needs to be passed as parameter

@hkantare
Copy link
Collaborator

hkantare commented Jun 4, 2020

@surajsub
Copy link
Author

surajsub commented Jun 9, 2020

Yes - that API specification is incomplete. If you need to provision a HPVS then you need to pass in the key.. We can make it an optional parameter.

@hkantare
Copy link
Collaborator

We need to pass the key as a value in parameter....Add the key(name and value ) in Parameters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants