ibm_pag_instance should force a new instance when parameters_json are…

… updated (#5807) * ibm_pag_instance should force a new instance when parameters_json are updated * Increasing the timeout for the test * Update .secrets.baseline * Updating the docs
IBM-Cloud · Nov 27, 2024 · 6d40699 · 6d40699
1 parent 72949de
commit 6d40699
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 22 deletions.
diff --git a/.secrets.baseline b/.secrets.baseline
@@ -3,7 +3,7 @@
     "files": "go.mod|go.sum|.*.map|^.secrets.baseline$",
     "lines": null
   },
-  "generated_at": "2024-11-15T07:40:53Z",
+  "generated_at": "2024-11-21T11:40:10Z",
   "plugins_used": [
     {
       "name": "AWSKeyDetector"
@@ -526,7 +526,7 @@
         "hashed_secret": "fd8bc0cb6ce2ef2fe2934f6d2d1ce1d648503740",
         "is_secret": false,
         "is_verified": false,
-        "line_number": 221,
+        "line_number": 256,
         "type": "Secret Keyword",
         "verified_result": null
       }
@@ -908,15 +908,15 @@
         "hashed_secret": "c8b6f5ef11b9223ac35a5663975a466ebe7ebba9",
         "is_secret": false,
         "is_verified": false,
-        "line_number": 2258,
+        "line_number": 2259,
         "type": "Secret Keyword",
         "verified_result": null
       },
       {
         "hashed_secret": "8abf4899c01104241510ba87685ad4de76b0c437",
         "is_secret": false,
         "is_verified": false,
-        "line_number": 2264,
+        "line_number": 2265,
         "type": "Secret Keyword",
         "verified_result": null
       }
@@ -2138,23 +2138,23 @@
         "hashed_secret": "deab23f996709b4e3d14e5499d1cc2de677bfaa8",
         "is_secret": false,
         "is_verified": false,
-        "line_number": 1366,
+        "line_number": 1373,
         "type": "Secret Keyword",
         "verified_result": null
       },
       {
         "hashed_secret": "20a25bac21219ffff1904bde871ded4027eca2f8",
         "is_secret": false,
         "is_verified": false,
-        "line_number": 1960,
+        "line_number": 1974,
         "type": "Secret Keyword",
         "verified_result": null
       },
       {
         "hashed_secret": "b732fb611fd46a38e8667f9972e0cde777fbe37f",
         "is_secret": false,
         "is_verified": false,
-        "line_number": 1979,
+        "line_number": 1993,
         "type": "Secret Keyword",
         "verified_result": null
       }
@@ -2164,7 +2164,7 @@
         "hashed_secret": "2317aa72dafa0a07f05af47baa2e388f95dcf6f3",
         "is_secret": false,
         "is_verified": false,
-        "line_number": 190,
+        "line_number": 277,
         "type": "Secret Keyword",
         "verified_result": null
       }
@@ -2250,7 +2250,7 @@
         "hashed_secret": "2317aa72dafa0a07f05af47baa2e388f95dcf6f3",
         "is_secret": false,
         "is_verified": false,
-        "line_number": 145,
+        "line_number": 251,
         "type": "Secret Keyword",
         "verified_result": null
       }
@@ -2260,15 +2260,15 @@
         "hashed_secret": "728e83f156932be9b1dc48a5c3f7a3bfbeeb08ce",
         "is_secret": false,
         "is_verified": false,
-        "line_number": 472,
+        "line_number": 531,
         "type": "Secret Keyword",
         "verified_result": null
       },
       {
         "hashed_secret": "2317aa72dafa0a07f05af47baa2e388f95dcf6f3",
         "is_secret": false,
         "is_verified": false,
-        "line_number": 650,
+        "line_number": 709,
         "type": "Secret Keyword",
         "verified_result": null
       }
@@ -2662,15 +2662,15 @@
         "hashed_secret": "b02fa7fd7ca08b5dc86c2548e40f8a21171ef977",
         "is_secret": false,
         "is_verified": false,
-        "line_number": 276,
+        "line_number": 275,
         "type": "Secret Keyword",
         "verified_result": null
       },
       {
         "hashed_secret": "d4c3d66fd0c38547a3c7a4c6bdc29c36911bc030",
         "is_secret": false,
         "is_verified": false,
-        "line_number": 314,
+        "line_number": 313,
         "type": "Secret Keyword",
         "verified_result": null
       }
@@ -2922,7 +2922,7 @@
         "hashed_secret": "b732fb611fd46a38e8667f9972e0cde777fbe37f",
         "is_secret": false,
         "is_verified": false,
-        "line_number": 1173,
+        "line_number": 1172,
         "type": "Secret Keyword",
         "verified_result": null
       }
@@ -4520,7 +4520,7 @@
         "hashed_secret": "165722fe6dd0ec0afbeefb51c8258a177497956b",
         "is_secret": false,
         "is_verified": false,
-        "line_number": 28,
+        "line_number": 25,
         "type": "Hex High Entropy String",
         "verified_result": null
       }
@@ -4530,7 +4530,7 @@
         "hashed_secret": "354fe46ea7cceda3813bfa9d7541d0922f1c45d0",
         "is_secret": false,
         "is_verified": false,
-        "line_number": 27,
+        "line_number": 24,
         "type": "Hex High Entropy String",
         "verified_result": null
       }
@@ -4540,7 +4540,7 @@
         "hashed_secret": "354fe46ea7cceda3813bfa9d7541d0922f1c45d0",
         "is_secret": false,
         "is_verified": false,
-        "line_number": 26,
+        "line_number": 23,
         "type": "Hex High Entropy String",
         "verified_result": null
       }

diff --git a/ibm/service/pag/resource_ibm_pag_instance.go b/ibm/service/pag/resource_ibm_pag_instance.go
@@ -16,6 +16,13 @@ import (
 func ResourceIBMPag() *schema.Resource {
 	riSchema := resourcecontroller.ResourceIBMResourceInstance().Schema
 
+	riSchema["parameters_json"] = &schema.Schema{
+		Type:        schema.TypeString,
+		Description: "PAG parameters to pass in Json string format",
+		ForceNew:    true,
+		Optional:    true,
+	}
+
 	return &schema.Resource{
 		Create:   resourcecontroller.ResourceIBMResourceInstanceCreate,
 		Read:     resourcecontroller.ResourceIBMResourceInstanceRead,

diff --git a/ibm/service/pag/resource_ibm_pag_instance_test.go b/ibm/service/pag/resource_ibm_pag_instance_test.go
@@ -185,9 +185,9 @@ func testAccCheckIBMResourceInstanceBasic(cos_instance_name string, cos_bucket_n
 		  }
 		)
 		timeouts {
-		  create = "15m"
-		  update = "15m"
-		  delete = "15m"
+		  create = "30m"
+		  update = "30m"
+		  delete = "30m"
 		}
 	  }
 	  

diff --git a/website/docs/r/pag_instance.html.markdown b/website/docs/r/pag_instance.html.markdown
@@ -144,8 +144,8 @@ The `ibm_resource_instance` resource provides the following [Timeouts](https://w
 ## Argument reference
 Review the argument references that you can specify for your resource. 
 
-- `location` - (Required, String) Target location or environment to create the PAG instance.
-- `parameters_json` - (Required, String) Parameters to create PAG instance. The value must be a JSON string.
+- `location` - (Required, Forces new resource, String) Target location or environment to create the PAG instance.
+- `parameters_json` - (Required, Forces new resource, String) Parameters to create PAG instance. The value must be a JSON string.
 
   Nested scheme for `parameters_json`:
   - `cosinstance` - (Required, String) COS instance CRN to use for PAG.