Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibm_db2 should not support parameters, parameters_json or service #5825

Open
shemau opened this issue Nov 28, 2024 · 0 comments
Open

ibm_db2 should not support parameters, parameters_json or service #5825

shemau opened this issue Nov 28, 2024 · 0 comments

Comments

@shemau
Copy link

shemau commented Nov 28, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform IBM Provider Version

This is a provider issue and unrelated to terraform version. 1.5.7, 1.6.x and 1.9.2 are all affected.
This feature was added in 1.72.0-beta0 and this is the only current version of the provider impacted.

Affected Resource(s)

  • ibm_db2

Terraform Configuration Files

The following documented argument references are bad practice and should be removed.

The following undocumented argument references should be removed

  • parameters

Justification:

The service is required, must be specified, but only has one possible value. It also forces replace, even thou there is no value to change it to.

Both parameters and parameters_json are worse than redundant on a single service resource/data source.

  • Security exposure. The whole block is not sensitive thus all parameters passed is exposed in the logs. This may not be an issue now, but every change risks exposing something sensitive, like a subscription id or api key.
  • Confusion. The block allows values to be passed, eg version which causes an evaluation error (at least with value 12), or high_availability which is also an argument reference and can thus be both on and off at the same time.

The blocks should only be used for generic resources, eg ibm_resource_instance where the provider can not be expected to know every option for every service.

Debug Output

Panic Output

Expected Behavior

Actual Behavior

Steps to Reproduce

  1. terraform apply

Important Factoids

References

  • #0000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant