Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More spohisticated retry for iam #14

Open
bartlomiej-malecki opened this issue Nov 22, 2023 · 1 comment
Open

More spohisticated retry for iam #14

bartlomiej-malecki opened this issue Nov 22, 2023 · 1 comment

Comments

@bartlomiej-malecki
Copy link
Member

Currently ibm iam client can be initialized with number of retries via aws.Config

https://github.com/IBM/ibm-cos-sdk-go/blob/master/aws/credentials/ibmiam/tokenmanager/client.go#L65

It will retry the failed request even if the response was e.g. 404

Ideally - ibm iam client could also use Retryer from config
https://github.com/IBM/ibm-cos-sdk-go/blob/master/aws/config.go#L108

	// Retryer guides how HTTP requests should be retried in case of
	// recoverable failures.
	//
	// When nil or the value does not implement the request.Retryer interface,
	// the client.DefaultRetryer will be used.
	//
	// When both Retryer and MaxRetries are non-nil, the former is used and
	// the latter ignored.
	//
	// To set the Retryer field in a type-safe manner and with chaining, use
	// the request.WithRetryer helper function:
	//
	//   cfg := request.WithRetryer(aws.NewConfig(), myRetryer)
	//
	Retryer RequestRetryer

https://github.com/IBM/ibm-cos-sdk-go/blob/master/aws/request/retryer.go#L20:L35

@avinash1IBM
Copy link
Member

We will look into this ticket. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants