Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError when no integrations are specified in base.yml #116

Open
nisarg73 opened this issue Aug 2, 2020 · 2 comments
Open

TypeError when no integrations are specified in base.yml #116

nisarg73 opened this issue Aug 2, 2020 · 2 comments

Comments

@nisarg73
Copy link
Member

nisarg73 commented Aug 2, 2020

Describe the bug
Backend throws a TypeError if integrations is left blank in base.yml.

This is because in

_CONF.integrations is None and hence not iterable here.

To Reproduce
Make integrations blank in base.yml

Expected behavior
There should be a check first, to see if integrations is None or not, to avoid this TypeError

Operating System:

  • OS: Linux
  • Browser: Firefox

Want to take up?
Sure

@nisarg73
Copy link
Member Author

nisarg73 commented Aug 2, 2020

Note that this check should be made in all the apps and services, where integrations is used. For example, in Facapp (https://github.com/IMGIITRoorkee/omniport-app-faculty-profile/blob/508c205ecc2de8dc1e9fad052e9d34d334f41ae5/views.py#L279) would throw an AttributeError here if integrations is None

@pradumangoyal
Copy link
Member

pradumangoyal commented Aug 3, 2020

In the base_stencil.yml, integration was marked as a required field with an empty dictionary by default. People mostly clone the configuration files from the documentation as it is and the files there are bit outdated. That is meant to be updated with the above-suggested change, and consecutively TypeError will be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants