Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use react-redux for subscriptions, pv handlers etc. #24

Open
rerpha opened this issue Aug 1, 2024 · 2 comments
Open

use react-redux for subscriptions, pv handlers etc. #24

rerpha opened this issue Aug 1, 2024 · 2 comments
Assignees

Comments

@rerpha
Copy link
Contributor

rerpha commented Aug 1, 2024

we should split up InstrumentData to use react-redux and pass just the data into the react components.

@rerpha rerpha mentioned this issue Sep 12, 2024
2 tasks
@rerpha rerpha self-assigned this Sep 16, 2024
@rerpha
Copy link
Contributor Author

rerpha commented Sep 18, 2024

interesting notes here: https://redux.js.org/usage/nextjs#overall-recommendations

For App Router applications we recommend that you should:

  • only use Redux for globally shared, mutable data
  • use a combination of Next.js state (search params, route parameters, form state, etc.), React context and React hooks for all other state management.

socket.io (we're not actually using this, though we probably could use it for the client part instead of react-use-websocket) seems to think using a useeffect is still the best way of using a ws https://socket.io/how-to/use-with-react

@rerpha
Copy link
Contributor Author

rerpha commented Oct 1, 2024

i'm not sure how middleware works with our gh-pages instance either - worth considering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant