Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests not discoverable due in VS Code due to --mypy flag #135

Closed
alexdewar opened this issue Oct 16, 2024 · 0 comments · Fixed by #136
Closed

Tests not discoverable due in VS Code due to --mypy flag #135

alexdewar opened this issue Oct 16, 2024 · 0 comments · Fixed by #136
Assignees
@AdrianDAlessandro
Labels
bug Something isn't working

Comments

@alexdewar
Copy link
Collaborator

Given that a lot of devs use VS Code, being able to use the built-in test runner is a useful QoL thing.

We can possibly fix this in the same way @AdrianDAlessandro has done, by running mypy directly as a CI job instead and dropping the pytest-mypy plugin: https://github.com/ImperialCollegeLondon/MEDUSA/pull/180

Note that in any case we are still running mypy as a pre-commit hook.
@alexdewar alexdewar added the bug Something isn't working label Oct 16, 2024
@AdrianDAlessandro AdrianDAlessandro self-assigned this Oct 16, 2024
@AdrianDAlessandro AdrianDAlessandro mentioned this issue Oct 16, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdrianDAlessandro AdrianDAlessandro

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove pytest-mypy ImperialCollegeLondon/python-template
2 participants
@alexdewar @AdrianDAlessandro