Skip to content
This repository has been archived by the owner on Dec 23, 2024. It is now read-only.

Degraded state? #63

Closed
tangtony opened this issue May 23, 2019 · 3 comments
Closed

Degraded state? #63

tangtony opened this issue May 23, 2019 · 3 comments
Labels

Comments

@tangtony
Copy link

When a non-fatal check fails, the top level status is still "ok". Is the intent that you have to check each component for success in order to determine if the service is actually 100% ok?

Would it be possible to add support for a degraded state or something along the lines of "there are failures, but nothing fatal"?

@schigh
Copy link
Contributor

schigh commented Sep 26, 2019

@tangtony apologies for the late response.

I do like this idea. Could you maybe expand upon it a bit? I'm thinking in terms of how to best use that information in a consumer...a readiness probe for example. How could we unambiguously say "there are some failures, but nothing fatal" to a listening process?

@schigh schigh added the v3 version 3 label Oct 3, 2019
@dselans
Copy link
Contributor

dselans commented Jan 31, 2021

I think that's exactly it - if a non-fatal service fails, then the lib can return a 2xx (other than 200) and a JSON status of degraded. Seems legit?

@maxclaus
Copy link
Member

This project is no longer actively supported and will be archived. Therefore all issues and pull requests are being closed. Please, feel free to fork it and apply the proposed change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants