Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic font fallbacks & prune some unused styles #1

Closed
moritz89 opened this issue Jan 27, 2023 · 0 comments
Closed

Add generic font fallbacks & prune some unused styles #1

moritz89 opened this issue Jan 27, 2023 · 0 comments

Comments

@moritz89
Copy link
Member

From: jagenjo/litegraph.js#294

  • added generic fallback (sans-serif) to every font specification
  • enclosed all explicit font names in quotes for consistency and visual difference
  • h1 and h2 elements don't seem to be used anywhere outside of the docs, so I pruned them from litegraph-editor.css and editor/style.css

This makes the UI look better on Linux which doesn't have fonts like Tahoma and Verdana. Personally, I would go further and re-do all of the font assignment based on Boostrap 5's system font stack, to quote, "for optimum text rendering on every device and OS".
But it's be up to the maintainer to say whether this is desirable :)

@atlasan might want to take a look at this as well, since I see they've been editing the CSS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant