Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polymorphic events are used in SM without the correct mapping to UML integration exists #85

Closed
gbatori1 opened this issue Jun 10, 2015 · 2 comments

Comments

@gbatori1
Copy link
Collaborator

The EATF model (sent to Akos, Abel earlier) contains polymorphic events but there is no mapping defined for them in the UML Integration. The expected outcome of using the EATF model is an error from the Mode Compiler but by checking the UML Integration and CPP model I realized that the polymorphic events are mapped to normal XTClassEvents and used in subtype State Machines which is wrong behavior of the Model Compiler.

Example:
CallLeg21Established defined in the CallLeg Class and it is used for example in the subtype CircuitSwitchLeg Class.

Until the polymorphic events are introduced when only those XTClassEvents, which have corresponding UML Signals, are allowed to be assigned to a transition of a State Machine which have a corresponding UML Reception defined in the same UML Class as the State Machine. So during transformation the UML Signal, UML SignalEvent, UML Reception should be taken into consideration.

@abelhegedus
Copy link
Member

@gbatori1 What is the expected behavior here?

We can either:

  • transform the transition but not set the trigger
  • ignore the transition altogether

In both cases, the output XTUML can be used for code generation. In my opinion the correct behavior would be to validate this on the UML model level, but no such validation is available.

@gbatori1
Copy link
Collaborator Author

The model was correct so UML validation won't show error. The problem is that the mentioned Signal, Reception, SignalEvent should be translated to a XTClassEvent + XTPolimorphicEvent instead of a single XTClassEvent. As this mapping is not yet implemented the expected behavior would be a transition without the trigger set.

abelhegedus added a commit that referenced this issue Jun 16, 2015
Fixed Trigger mapping to require Reception #85
@itsdani itsdani closed this as completed Jun 17, 2015
@abelhegedus abelhegedus modified the milestone: June-2015 Jul 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants