Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes of IEDC Excel data template and export routines #5

Open
stefanpauliuk opened this issue Sep 6, 2018 · 7 comments
Open

Changes of IEDC Excel data template and export routines #5

stefanpauliuk opened this issue Sep 6, 2018 · 7 comments

Comments

@stefanpauliuk
Copy link
Member

Note necessary and optional changes here so that they can be reviewed and become part of next version.

@nheeren
Copy link
Member

nheeren commented Sep 6, 2018

So this is something like a wishlist 🎄?
Let me add one thing. Parsing the Cover sheet was a quite tedious. We should rethink that. I can make a proposal.

@stefanpauliuk
Copy link
Member Author

Sure, we can design a version 2 format.
Note that the left part of the cover sheet is just a 1:1 copy of the dataset table entry. Here we don't have much flexibility.

@nheeren
Copy link
Member

nheeren commented Nov 24, 2018

Another thing: IMO there should be no distinction between TABLE and LIST type data. The LIST type is basically a simple from of the TABLE type. Therefore the definitions of aspects & classifications (currently in the Cover sheet) should be 100% harmonized between the two.
Right now I have to use a lot of case distinctions in my code which could be simplified then.

@stefanpauliuk
Copy link
Member Author

When creating a custom classification directly from the data template, we have now:
classification_Name = aspect_datasetName, e.g. commodity__1_F_steel_SankeyFlows_2008_Global

Please change the parser to do the following:

  • for description: from "generated by IEDC_tools v0.2" to "Custom classification, generated by IEDC_tools v0.2"
  • for meaning_attribute1: from "None" to "[aspect] aspect of dataset"

@nheeren
Copy link
Member

nheeren commented Feb 5, 2019

  • for meaning_attribute1: from "None" to "[aspect] aspect of dataset"

Do you mean that literally or should "[aspect]" be replaced with something? Please give an example.

@stefanpauliuk
Copy link
Member Author

Please replace [aspect] by the actual aspect (aspect.aspect for aspect.id = datasets.aspectx).
E.g.
"origin_region aspect of dataset"
"age-cohort aspect of dataset"

@nheeren
Copy link
Member

nheeren commented Feb 6, 2019

  • for description: from "generated by IEDC_tools v0.2" to "Custom classification, generated by IEDC_tools v0.2"
  • for meaning_attribute1: from "None" to "[aspect] aspect of dataset"

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants