-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"patch" is not recognized on Windows 10 #10
Comments
Hi @ThomasPujolle . Thanks for reporting this! Building relocatable-python 3.8 on Windows may be tricky, because it requires multiple pieces of software of specific versions, and the process may be coupled pretty tightly to the environment we use on our side. I'm glad you're trying to build it so we can hash out some of the missing pieces, either in the documentation or through the code. We use Cygwin to install a few unix packages that are needed for building. When installing Cygwin you can choose a list of packages to install. "patch" is apparently required, but there could be other packages required, like "autoconf", "libtool" etc. For the record here is the full list of packages we have on our Cygwin deployment (not all of them are needed):
Let us know if this helps. |
Ok, so I did install the missing packages in Cygwin, it fixed the issues for most calls and for the rest I just had to change binary path in the buildout-build-windows.cfg. I also had to use Curl 5.24 installed manually without using curl from Cygwin. Some errors remains though:
Any idea where that is comming from ? I tried to skip one but there are plenty more after. Thanks for your help |
I synced the source files. Please try again with the original package names. |
Ok much better, it went on for a while and then stopped here:
I think iconv was not properly build earlier, here is the outcome:
Sorry for the french, it seems there was an issue with Visual Studio Edit: I changed 2017 for 2019 since I have visual studio community 2019. Code is running, will update on results. is different on VS2019, it's This path Config updated, code running. |
Still no luck, although it does not seem too hard to fix, some path are just wrong (due to VS 2019) and need fixing after an error is thrown during compilation. |
Moving from Visual Studio 2010 to 2017 wasn't simple. I'm afraid making the build work with VS 2019 will not be an easy task, too. At this point, I'm afraid VS 2017 is a requirement. This is also the version that the Python dev team is using, by the way (https://devguide.python.org/setup/#windows). |
All right, since you kindly provided those builds I guess the way forward would be to use one of them without re-building everything. Did you have to update your scripts for each version of python ? If you have 3.6 and 3.7 for Windows hidden somewhere that would be perfect for me. Another thing, the first thing I tried with python v3.8.0.3 & python 3.5.1.9 was to install pip. It went well but I got an error while trying to upgrade it using the famous
|
We didn't encounter this issue. We will try to reproduce on our local environment. |
Our relocatable-python package does not come with pip so the output of the command was "No module named pip". After installing with "get-pip", the command works. I also tried with virtualenv (although we don't really use it - relocatable-python is an isolated environment of its own) and couldn't reproduce. |
Okay, I initially installed pip with PyCharm so there is a chance that the command used was not the same. As per environments with python 3.6 and 3.7, what would be the course of action? Does your work has to be adapted for each new version of Python? Should this conversation be taken some place else since we are getting further away from the initial subject? |
The code generally needs to be adapted for new versions of Python. We have a branch for Python 3.7 but it does not include Windows support. We have no version of Python 3.6. We made the jump from 3.5 directly to 3.8. |
Hello,
I've tried to run your script using the develop branch, on Windows 10, with administrator rights, I got an error saying "patch is not recognized as an internal command".
I then installed "patch" from here http://gnuwin32.sourceforge.net/ but it didn't fix the issue, the binaries seem old ... any idea?
The text was updated successfully, but these errors were encountered: