Last image in post content has incorrect src & srcset (substitutes from the first image)

[LeTraceurSnork]

Describe the bug
Last image from post content (post_type=post) duplicates first image of the same post (if more than one image presents) when WooCommerce enabled alongside with ilab-media-tools plugin (WordPress store link)

Here's what I did: fresh WordPress, only WooCommerce and Media Tools installed. Twentytwentyfive theme, new post, 3 images (pic rel). While plugins is disabled, I get this:

When any of two plugins enabled by its own, the picture is the same, but when I enable two of them simultaneously, I get this picture:

To Reproduce

1. Install fresh WordPress
2. Install WooCommerce and Media Tools plugin
3. Set Media Tools up with any data (important part is to turn Enable Cloud Storage checkbox on)
4. Create a post with at least two images in its content
5. Open the post and ensure of the bug

Expected behavior
Last image of the post renders as it is

Screenshots
If applicable, add screenshots to help explain your problem.

Server (please complete the following information)
Server Info: Apache/2.4.62 (Debian)
PHP Version: 8.1.31
PHP Post Max Size: 8 MB
PHP Time Limit: 30
PHP Max Input Vars: 1000
cURL Version: 7.88.1
OpenSSL/3.0.15
WordPress 6.7.1

How did you install the plugin?
Via composer from wpackagist

Additional context
Same issue in WooCommerce repo: woocommerce/woocommerce#56333
The bug appears only when Enable Cloud Storage checkbox is on, even if images are uploaded locally in wp-content/uploads and only when Replace URLs checkbox is on

[LeTraceurSnork]

Okay, finally figured io out
So, we have \Automattic\WooCommerce\Blocks\BlockTypesController::add_data_attributes() and its trim( $content ); line
And now we have \MediaCloud\Plugin\Tools\Storage\StorageContentHooks::fixGutenbergFigures() with its preg_matches. The problem is that preg_match is greedy by default and specifically preg_match('/class\s*=\s*(?:.*)wp-image-([0-9]+)/m', $figureMatch, $imageIdMatches) seems to match ALL the trimmed string, which would be all of the post content's HTML.

Here's a PR that fixes this behavior, please, accept it ASAP
#248

[LeTraceurSnork]

@jawngee

[jawngee]

I will get on this later this week, early next week. I'm in the middle of opening a retail store. :)

…

On Mar 17, 2025, at 12:49 PM, LeTraceurSnork ***@***.***> wrote: LeTraceurSnork left a comment (Interfacelab/ilab-media-tools#245) @jawngee — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned. <https://github.com/jawngee> <#245 (comment)> <https://github.com/notifications/unsubscribe-auth/AAAK3ILK7CE4FC642VU3IAD2UZO5FAVCNFSM6AAAAABY3WAGGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRYGIZTSMRQGM> LeTraceurSnork left a comment (Interfacelab/ilab-media-tools#245) <#245 (comment)> @jawngee <https://github.com/jawngee> — Reply to this email directly, view it on GitHub <#245 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAK3ILK7CE4FC642VU3IAD2UZO5FAVCNFSM6AAAAABY3WAGGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRYGIZTSMRQGM>. You are receiving this because you were mentioned.