Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generation size is still slightly different from selection size #116

Open
R4rum opened this issue Feb 4, 2023 · 5 comments
Open

Generation size is still slightly different from selection size #116

R4rum opened this issue Feb 4, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@R4rum
Copy link

R4rum commented Feb 4, 2023

Describe the bug
I think these two lines of log speak for themselves:
auto-sd-paint-ext:INFO: img size: 1374x1054 -> 1374x1054, aspect ratio: 1.30 -> 1.30, 0.00% change
auto-sd-paint-ext:INFO: img Size: 1368x1048, target: 1374x1054

That latter one is from after the generation. Note how the size has changed.

Desktop (please complete the following information):

  • OS: Linux
  • WebUI commit revision 226d840e84c5f306350b0681945989b86760e616
  • Extension commit revision 2358931
@R4rum R4rum changed the title Still a small aspect ratio change Generation size is still slightly different from selection size Feb 4, 2023
@RainehDaze
Copy link

image

The new img size is under your max size and it's generating a larger image then downscaling, I think.

@R4rum
Copy link
Author

R4rum commented Feb 4, 2023

This result of mine was gotten with the Disable base/max size checked. Probably it's easier to get that weirdness to happen like that but I would imagine it's not impossible with the base/max size system either; I feel like it's happened even then.

@RainehDaze
Copy link

Looking at the numbers, it might be that your image dimensions have to be divisible by 8 and it rounded down to the nearest size it can generate.

@R4rum
Copy link
Author

R4rum commented Feb 4, 2023

I think you are right. I looked at a whole bunch of resolutions it generates at, and they all came out divisible by 8.

It seems we come back to this comment, then, since some striding is still needed apparently. #113 (comment)

Interpause added a commit that referenced this issue Feb 9, 2023
@Interpause
Copy link
Owner

I wonder if there is somewhere inside the webUI code were the stride value is stored.

@Interpause Interpause added the bug Something isn't working label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants