-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Surface DLR docs for deep linking #246
Comments
This repo is no longer Microsoft owned so I have no idea about getting it on Microsoft Docs. Making it available on the wiki would be reasonable. As for the headings remaining the same, if the docs are simply markdown versions of the original docs then I see no reason why any of it would change. |
I propose to do the following:
Is this a good plan? @slozier, do you have any other thoughts on this? |
@zspitz Sounds like a plan. |
Well, it's been 2.5 months, and I think I've automated as much of the conversion as I can. (It's been an interesting journey -- along the way I developed a library for writing Pandoc filters in .NET languages, and the actual conversion source is here). The result of the conversion is attached to this comment. @slozier I think there are still some corrections to be taken care of. Among others, I think the entire section of the API reference for expression trees (and perhaps other documents) should be replaced with a link to the appropriate Microsoft documentation. But if you feel the quality is good enough, would you consider putting this in its current state in the wiki? At least to check that internal links, sidebars, page headings all work. I would be willing to carry out the editing I described above, but either 1. the wiki would have to be writable to everyone, or 2. I'd need write permissions on the repo. Per the GitHub docs:
|
Very nice. I tried loading the docs in the wiki but it doesn't seem to handle it very well, maybe I'm missing something. Perhaps another option would be to host it via GitHub Pages. Any thoughts? |
I wanted to preserve the numbering in the text, while keeping the numbers out of the hashtag document fragments. But the wiki system inserts I don't have any experience using GitHub Pages, but it looks like it would be a better option. I'm guessing I'd be able to fork the main repo, create the While it's possible to configure GitHub Pages to use the |
I had noticed that as well. We can move the doc/pdf files to another location. It could be a subfolder of docs and then be made available for download via a link in the markdown. |
The GitHub Pages on my fork can be seen here. The links between documents are working. It seems a little plain. Do you have any suggested improvements? |
It does seem a little plain, but we can probably make it a bit more colorful by adding a theme via There's a typo in: "DLR Hostirng Spec" |
Thanks for the typo; I've corrected it. I've also reformatted the first-level headers in the TOC to a higher level, in order to emphasize them within the TOC. If I understand correctly, putting the TOC in some kind of sidebar would involve customizing the layout. I'll look into it further next week. I suspect that some of the header titles are going to be too wide for a sidebar. Do you have any suggestions? Also, at some point I think it appropriate to merge the docs from my fork into the main branch. When is the right time to do so? |
@zspitz Looking nice indeed! |
@thetuvix As one of the original authors of the documentation in question (I wasn't able to find current contact information for Bill Chiles), do you know who has the current copyright? What form of credit is appropriate? Also, if you have any other feedback, I would be very interested to hear it. |
I've written a Visual Studio custom debugging visualizer for expression trees (and other types in System.Linq.Expressions.Expression).
I would like to expose links to the documentation at https://github.com/IronLanguages/dlr/tree/master/Docs from within the visualizer's context menu, much like I already link to the standard Microsoft documentation. Specifically, to
expr-tree-spec
anddlr-overview
. Currently, the files are stored as PDFs and Word documents, which means it's impossible to link within these files, only to the files themselves.Are there any plans to move this documentation to Microsoft Docs? Or, perhaps to the wiki section on this repo? Or some other globally available host? Presumably it would be easier to work with these files in Markdown; I would be willing to carry out this conversion.
If the documentation is moved to the wiki, what guarantees would I have that the headings -- required for deep linking -- would remain the same?
The text was updated successfully, but these errors were encountered: