-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRTM v3.1.1-build1 builds little-endian binaries #1561
Comments
Which version of CRTM? |
3.1.1-build1. I'll update the description. |
Related CRTM issue: JCSDA/CRTMv3#212. |
@BenjaminTJohnson @stiggy87 Can you take a look, please? |
If any changes are needed to spack-stack-1.9.1, they will be made in an addon/chained environment. We are not able to hold off the release of spack-stack-1.9.1 and reinstall the release everywhere, sorry. |
Noted and thanks @climbfuji. |
@climbfuji @AlexanderRichert-NOAA @stiggy87 @BenjaminTJohnson $ icx -big-endian test.c
icx: command line warning #10430: Unsupported command line options encountered
These options as listed are not supported.
For more information, use '-qnextgen-diag'.
option list:
-big-endian Running The CRTM is able to work with both binary and netCDF files. I'm not sure if the best option here is to move to little-endian binaries or netCDF. I'm not at all familiar with the inner workings of the CRTM, so I'm not sure if moving to little endian is an option. I also know that this would have repercussions on the GSI, UPP, and the GDASApp. Though I don't believe @wx20jjung has tested it, I suspect that v2.4.1 will encounter the same problems when compiled with OneAPI compilers. |
A major effort in the CRTMv3 development is the move away from these horrible binary files towards netCDF. I wouldn't spend any effort on big endian vs little endian if the netCDF implementation is fully supported and working. @BenjaminTJohnson Can you comment on this, please? |
That being said, aren't you reading and writing unformatted files with Fortran, not C/C++?
I just recently needed that for an NRL project. |
@climbfuji Hmm, good point. I thought I had the answer there. And I see that the CRTM is mostly Fortran, so that |
@DavidHuber-NOAA @climbfuji I use the That being said, currently working on getting everything all netcdf default in v3.2.0. We'll still support binary i/o, but won't carry those files in the tarball anymore. v3.2.0 Release is overdue, waiting on EMC feedback. |
Describe the bug
The CRTM (v3.1.1-build1 in spack-stack 1.9.0-1) is building little-endian binaries when big-endian are required. (Reported by @wx20jjung).
To Reproduce
Attempt to read in the default CRTM-fix binaries (which are big-endian). The CRTM will fail with errors on endianness.
Expected behavior
The CRTM should be able to read the binary fix files without issue.
System:
Noticed on Orion, but possibly other systems.
The text was updated successfully, but these errors were encountered: