Merge pull request #526 from AlexanderRichert-NOAA/nc_test_fix

netcdf-{c,fortran}: run tests on run_tests, not run_after(install)

Author: AlexanderRichert-NOAA

var/spack/repos/builtin/packages/netcdf-c/package.py

@@ -561,8 +561,11 @@ def configure_args(self):
 
     # It looks like the issues with running the tests in parallel were fixed around version 4.6.0
     # (see https://github.com/Unidata/netcdf-c/commit/812c2fd4d108cca927582c0d84049c0f271bb9e0):
-    @when("@:4.5.0")
     @run_after("install")
-    def check(self):
+    def run_checks(self):
         # h5_test fails when run in parallel
-        make("check", parallel=False)
+        if self.pkg.run_tests:
+            make("check", parallel=self.spec.satisfies("@4.6:"))
+
+    def check(self):
+        pass

var/spack/repos/builtin/packages/netcdf-fortran/package.py

@@ -158,9 +158,13 @@ def configure_args(self):
         return config_args
 
     @run_after("install")
-    def check(self):
+    @on_package_attributes(run_tests=True)
+    def run_checks(self):
         make("check", parallel=self.spec.satisfies("@4.5:"))
 
+    def check(self):
+        pass
+
     @run_after("install")
     def cray_module_filenames(self):
         # Cray compiler searches for module files with uppercase names by