Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'scrape' option limited by filepath expectations #12

Closed
mfarina1 opened this issue Oct 11, 2024 · 2 comments
Closed

'scrape' option limited by filepath expectations #12

mfarina1 opened this issue Oct 11, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mfarina1
Copy link
Collaborator

mfarina1 commented Oct 11, 2024

NOTE: this issue is copied over from archived anms-camp repo found here

Because the scrape option expects the original file to be in the same exact structure as how camp outputs files, it limits the organization of files in other repositories which rely on camp outputs.

anms-camp/src/camp/generators/create_impl_h.py

Line 43 in 1302277
scrape_src = full_path if scrape and os.path.exists(full_path) else None

For example, in the reference implementation dtnma-tools, files under src/ion_if/bpv7/adm will never get scraped correctly because they do not live under a directory named agent.

Additionally, the scrape (roundtripping) behavior as described in the README is out of date (the -c and -h flag options, which sound like desirable behavior, do not exist).

@mfarina1 mfarina1 added the enhancement New feature or request label Oct 11, 2024
@mfarina1 mfarina1 added this to the CAMP v3.0.0 milestone Oct 11, 2024
@mfarina1
Copy link
Collaborator Author

Using the new Agent API should resolve this issue, but the problem does still exist on the main branch. It will be resolved when we merge apl-fy24 into main

@mfarina1
Copy link
Collaborator Author

Closing as OBE due to PR #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants