Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.11.0-- Warning: Backwards Incompatible Changes Incoming #14

Open
JRG-Developer opened this issue Aug 23, 2016 · 8 comments
Open

Comments

@JRG-Developer
Copy link
Owner

This is advance notice that version 0.11.0 will introduce backwards incompatible changes:

  • Minimum version will be iOS 8.0 or newer
  • ALTableViewCellFactory will be deprecated in favor of ALAutomaticTableViewCellFactory, which differs in that it uses Apple's suggested way to calculate dynamic cell height (instead of using UIVIew methods to do this).
  • Fix will be provided for Leading label does not match separator margin #12

I've setup a new branch called 0.11.0 where changes will be made for now.

I'm open to suggestions for other improvements, including non-backwards ones, that would be beneficial. ;)

@AnthonyMDev @ankamsandeep

@JRG-Developer JRG-Developer changed the title Version 0.11.0-- Warning: Incompatible Changes Incoming Version 0.11.0-- Warning: Backwards incompatible Changes Incoming Aug 23, 2016
@JRG-Developer JRG-Developer changed the title Version 0.11.0-- Warning: Backwards incompatible Changes Incoming Version 0.11.0-- Warning: Backwards Incompatible Changes Incoming Aug 23, 2016
@AnthonyMDev
Copy link
Collaborator

@JRG-Developer Thanks for the heads up. Moving to 8.0 is fine with me. Looks like these changes are for the better.

@AnthonyMDev
Copy link
Collaborator

@JRG-Developer Have you been using 0.11.0 in production? I'm about to integrate the new beta version into my applications. If it seems to work out well, I'd suggest that we may be ready to push a stable version.

@JRG-Developer
Copy link
Owner Author

I have been using it in production, but I need to look at this again...

Honestly, I kinda cheated and skipped some tests here... this is main reason why it's a "beta"...

;)

@AnthonyMDev
Copy link
Collaborator

Haha we've all been there. We just don't like to talk about it. ;)

Alright, I'm almost done integrating it. Once I've used it for a few days and had some extensive testing done with it, I'll report back and let you know what I find out.

I also made 1 commit to the 0.11.0 branch earlier today. If you have questions about why I made that change, feel free to ask for details.

@AnthonyMDev
Copy link
Collaborator

@JRG-Developer I've been testing 0.11.0 and have found no problems with it. I'd love to see a version pushed to the CocoaPods master spec repo when you get a chance.

If you need help writing some tests, let me know what areas the tests are missing and I may be able to help out. Or, if you are okay with pushing a release let me know and I can push the version myself.

@JRG-Developer
Copy link
Owner Author

@AnthonyMDev

Per #12, I'm considering changing the constraints on all cells to use the margin, instead of "10".

For my projects, this doesn't really matter... I use custom xibs or storyboard prototype cells exclusively (never the xibs provided).

Do you use these default xibs? Do you care one way or another?

It's probably best we do refer to the margins, as Apple is pushing this through their changes on table view, etc.

@AnthonyMDev
Copy link
Collaborator

I'm strongly in favor of using the margins. I'm using custom cells anyways, but I think the margins are appropriate for the stock cells.

@AnthonyMDev
Copy link
Collaborator

AnthonyMDev commented Jan 25, 2017

Any update on pushing a version? This is starting to make it more difficult for me to get apps that have transitive dependencies completed.

EDIT:
I fixed my issues by updating dependencies in my pod specs. I didn't realize we had actually pushed pre-release versions. Thought we were just depending on the beta 0.11.0 branch.

Still would be nice to have a release sometime soon though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants