-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 0.11.0-- Warning: Backwards Incompatible Changes Incoming #14
Comments
@JRG-Developer Thanks for the heads up. Moving to |
@JRG-Developer Have you been using |
I have been using it in production, but I need to look at this again... Honestly, I kinda cheated and skipped some tests here... this is main reason why it's a "beta"... ;) |
Haha we've all been there. We just don't like to talk about it. ;) Alright, I'm almost done integrating it. Once I've used it for a few days and had some extensive testing done with it, I'll report back and let you know what I find out. I also made 1 commit to the |
@JRG-Developer I've been testing If you need help writing some tests, let me know what areas the tests are missing and I may be able to help out. Or, if you are okay with pushing a release let me know and I can push the version myself. |
Per #12, I'm considering changing the constraints on all cells to use the margin, instead of "10". For my projects, this doesn't really matter... I use custom Do you use these default It's probably best we do refer to the margins, as Apple is pushing this through their changes on table view, etc. |
I'm strongly in favor of using the margins. I'm using custom cells anyways, but I think the margins are appropriate for the stock cells. |
Any update on pushing a version? This is starting to make it more difficult for me to get apps that have transitive dependencies completed. EDIT: Still would be nice to have a release sometime soon though! |
This is advance notice that version
0.11.0
will introduce backwards incompatible changes:ALTableViewCellFactory
will be deprecated in favor ofALAutomaticTableViewCellFactory
, which differs in that it uses Apple's suggested way to calculate dynamic cell height (instead of usingUIVIew
methods to do this).I've setup a new branch called
0.11.0
where changes will be made for now.I'm open to suggestions for other improvements, including non-backwards ones, that would be beneficial. ;)
@AnthonyMDev @ankamsandeep
The text was updated successfully, but these errors were encountered: