Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linemasking post-rescale #16

Closed
LightArrowsEXE opened this issue Dec 22, 2022 · 3 comments
Closed

Linemasking post-rescale #16

LightArrowsEXE opened this issue Dec 22, 2022 · 3 comments

Comments

@LightArrowsEXE
Copy link
Member

A good additional operation to have for rescaling might be to mask it to lineart. This is a fairly standard rescaling operation as it reduces damage to grain and the like. Ergo, it would be nice if descale did this internally. Maybe worth looking at once you finish your vsmask rewrite?

@Setsugennoao
Copy link
Member

You can already do this, though it might not be super intuitive, through the mask param
You just have to pass an inverted mask

@LightArrowsEXE
Copy link
Member Author

Doesn't this override regular credit masking, however?

@Setsugennoao
Copy link
Member

Yeah
I will make the mask param a tuple with the first element being the error mask, the second being post-processing like linemasking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants