Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add borders param to descale #67

Closed
LightArrowsEXE opened this issue Feb 16, 2023 · 1 comment
Closed

Add borders param to descale #67

LightArrowsEXE opened this issue Feb 16, 2023 · 1 comment

Comments

@LightArrowsEXE
Copy link
Member

Zewia linked this package in SeaDex earlier today, claiming it helps resolve issues with messy edges pretty well. It's probably a good idea to explore these claims and see whether we can incorporate them into our own descale tool if they appear beneficial.

@LightArrowsEXE
Copy link
Member Author

Did a bit of testing, and the results seem pretty alright.

    descaled1 = BicubicSharp.descale(clip_y, **de_args)
    descaled2 = bdescale(clip_y, c=1, left=3, right=3, bottom=0, top=0, **de_args)

image
image

While they're not perfect, this alone seems to help a lot in suppressing ugly edge ringing. We should perform more testing, but for now I'm happy enough with these results to urge we add a similar functionality to descale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants