Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keep_ar has wrong output, does not match crop_resize script #83

Closed
ghost opened this issue Oct 7, 2023 · 2 comments
Closed

keep_ar has wrong output, does not match crop_resize script #83

ghost opened this issue Oct 7, 2023 · 2 comments

Comments

@ghost
Copy link

ghost commented Oct 7, 2023

example

wrong = vskernels.Catrom.scale(clip, width=1920, height=804, src_height=1606, src_top=277, keep_ar=True)
correct = crop_resize(clip, width=1920, height=804, src_height=1606, src_top=277)
@ghost
Copy link
Author

ghost commented Oct 8, 2023 •
edited by ghost
Loading

fixed by #23de387

@ghost ghost closed this as completed Oct 8, 2023
@Setsugennoao
Copy link
Member

for the record, was just preferring shift parameter over kwargs

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Setsugennoao