Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimizer sometimes fails to inline files #142

Open
JasonGross opened this issue Dec 12, 2022 · 2 comments
Open

Minimizer sometimes fails to inline files #142

JasonGross opened this issue Dec 12, 2022 · 2 comments
Labels
minimize more Issues related to getting the minimizer to do more minimization needs-test-case-to-reproduce

Comments

@JasonGross
Copy link
Owner

I'm going to use this thread to track undiagnosed minimization inlining failures. Once a failure is debugged, it should be edited and crossed off and linked to a separate issue about that particular failure.

@JasonGross JasonGross added needs-test-case-to-reproduce minimize more Issues related to getting the minimizer to do more minimization labels Dec 12, 2022
@JasonGross JasonGross pinned this issue Dec 12, 2022
@SkySkimmer
Copy link
Contributor

rocq-prover/rocq#17285 (comment)
Minimized file:

(* -*- mode: coq; coq-prog-args: ("-emacs" "-q" "-w" "unsupported-attributes" "-w" "-deprecated-native-compiler-option" "-R" "/github/workspace/builds/coq/coq-failing/_build_ci/bedrock2/deps/coqutil/src/coqutil" "coqutil" "-Q" "/github/workspace/cwd" "Top" "-Q" "/github/workspace/builds/coq/coq-failing/_install_ci/lib/coq/user-contrib/Ltac2" "Ltac2" "-top" "coqutil.Map.Interface" "-async-proofs-tac-j" "1" "-native-compiler" "no") -*- *)
(* File reduced by coq-bug-minimizer from original input, then from 151 lines to 13 lines, then from 18 lines to 13 lines *)
(* coqc version 8.18+alpha compiled with OCaml 4.14.1
   coqtop version runner-d7iyxycj-project-6138686-concurrent-0:/builds/coq/coq/_build/default,(HEAD detached at f78c2d7) (f78c2d73af34e54ff64fe829c96eb7e7fc160c90)
   Expected coqc runtime on this file: 0.121 sec *)
Require coqutil.sanity.
  Class map {key value} := mk {
    rep : Type;

    get: rep -> key -> option value;

    empty : rep;
    put : rep -> key -> value -> rep;
    remove : rep -> key -> rep;
    fold{R: Type}: (R -> key -> value -> R) -> R -> rep -> R;
  }.

The Require should be reducible to just Global Unset Universe Minimization ToSet.

Also the bot failed to mention that a file was not inlined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minimize more Issues related to getting the minimizer to do more minimization needs-test-case-to-reproduce
Projects
None yet
Development

No branches or pull requests

2 participants