Bug: potential information loss and maybe wrong offsets in new pivot-centered reference frame

[cameronc137]

Environment: (where does this bug occur, have you tried other environments)

• Develop geometry files

Geometry shifts aren't clearly doing what they should:

remoll/geometry/upstream/upstreamDaughter_merged.gdml

Line 24 in 701c7e8

<constant name="COLL1_z" value ="5575 - UOFFSET - MERGE_OFFSET"/>

It appears to me that the "UOFFSET" parameters are still using the old coordinate system. I think this may be ok, as the goal of the offset parameter was to let the user place the old-target-centric z positions of the components and have the daughter-volume's relative shift get un-shifted by this parameter.

Now, with the new-pivot-centric z position system these relative shifts w.r.t. the daughter's offset are all different. This is ok for all of the objects previously placed with the old-target-centric relative shifts in mind, but for any new object placed in with a pivot-centric frame daughter-offset we will need to make a new offset variable, and also the information of what is where is now all obfuscated by these two coexisting sources of position and shift information.

Are these UOFFSET numbers correct? Now that we are pivot centered should we go through and update all of the parameters to match the new correct coordinate system?