Skip to content

🐛 Bug: Feature issue template asks about pulling from main, weirdly #2217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks done
JoshuaKGoldberg opened this issue Apr 22, 2025 · 2 comments
Open
3 tasks done
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Each issue template should have fields relevant to just that type of issue. They also all ask to make sure you're looking at the current version of the thing in question. For the feature request template, I'd think it should ask that users are on the latest version of the package. Maybe:

- label: I have verified I've installed the latest version of the package
  required: true

Actual

Coming over from JoshuaKGoldberg/formatly#123 (comment):

Off topic: Creating new feature request has check "I have pulled the latest main branch of the repository.*" which feels weird, because I'm not cloning this repository to try this tool. I'm using it with npx / wishing new feature based on documentation.

- label: I have pulled the latest `main` branch of the repository.
required: true

Agreed 😄. It's a holdover from "adopting" the template from other places (read: copy & pasting).

Additional Info

This is a good first issue because it's a pretty direct example of the places you'd need to change logic for a single Block:

  • .github/ISSUE_TEMPLATE/03-feature.yml
  • src/blocks/blockGitHubIssueTemplates.ts
  • src/blocks/blockGitHubIssueTemplates.test.ts (which I normally auto-update with pnpm run test -u)

Co-authored-by: @rubiesonthesky

🎁

@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :( labels Apr 22, 2025
@JoshuaKGoldberg
Copy link
Owner Author

@all-contributors please add @rubiesonthesky for bug.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @rubiesonthesky! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Development

No branches or pull requests

1 participant