Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose reports of atomic models in EnsembleModel #746

Open
ablaom opened this issue Feb 28, 2021 · 2 comments
Open

Expose reports of atomic models in EnsembleModel #746

ablaom opened this issue Feb 28, 2021 · 2 comments

Comments

@ablaom
Copy link
Member

ablaom commented Feb 28, 2021 •
edited
Loading

We currently save (and expose) the learned parameters - fitresult in the code. I think it would make sense to accumulate both (fitresult, report) and make the atomic model reports available in the EnsembleModel report.
@ablaom ablaom mentioned this issue Feb 28, 2021
Closed
@ablaom
Copy link
Member Author

ablaom commented Feb 28, 2021

@jeremiedb Be great if you can have a go at this. Just put the feature importances in the report returned by fit; see the example here.

@ablaom
Copy link
Member Author

ablaom commented Feb 28, 2021

https://github.com/alan-turing-institute/MLJXGBoostInterface.jl/blob/325c22d3875d9b84540138817660aeb9b7f842fc/src/MLJXGBoostInterface.jl#L248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ablaom