-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logo? #316
Comments
Done with the following code: using Luxor
JULIA_COLORS = [Luxor.julia_blue, Luxor.julia_green, Luxor.julia_red, Luxor.julia_purple]
function main()
Drawing(500, 500, "/tmp/juliaperformance.svg")
origin()
squircle(O, 250, 250, :clip, rt=0.3)
sethue("white")
paint()
@layer begin
translate(0, 200)
rmin = 150
rmax = 260
band = 40
for n in 1:4
setblend(blend(O - (240, 0), O + (240, 0), "white", JULIA_COLORS[n]))
sector(O,
rescale(n, 1, 3, rmin, rmax),
rescale(n, 1, 3, rmin, rmax) + band,
3π / 2 - deg2rad(45), 3π / 2 + deg2rad(45),
:fill)
end
sethue("white")
setline(25)
line(O, polar(400, deg2rad(290)), :strokepreserve)
setline(14)
sethue("black")
strokepath()
circle(O, 30, :fill)
end
finish()
preview()
end
main() |
Love it! Where are you thinking the logo should go? The repository settings allow you to provide an image as a "social media preview" but I have no idea what that actually means. We could add it to the README. |
The "social media preview" is the image you get when people link to your site on those social media sites I hear so much about (do people still use Twitter?😱😀), usually a biggish rectangular image.... if there isn't one in settings you get (I think): ![]() You'd probably need to make something bigger than a logo (eg https://github.com/cormullion/Karnak.jl ) Sometimes there's a place for icon + link: eg on the Julia home page: ![]() Then there's the Documenter documentation - which has options to show and switch between light and dark mode logos. |
Yeah I was thinking social media preview + docs, and possibly readme. The only issue with the readme is that you can't adapt to the light/dark theme? |
You can:
|
I don't have access to the repo settings for the social media preview. @vchuravy gimme the power? |
Does anyone know why the Readme logo fails to show up? |
line 1 of readme doesn’t look like HTML code? |
Right, I tried to put the logo next to the title and it worked in the markdown preview of VSCode so I didn't think twice |
I can add the social media preview. Looks like the images here are square but the section in the settings says:
Indeed, putting the square one in there crops the height to fill the width. Does someone want to make a wide version? |
don’t tempt me … |
I am hereby tempting you |
You gave in to temptation |
Apologies for the delay. The fruit of @cormullion's temptation has been set as the social media preview. What's left to consider this issue complete? Adding the logo to the Documenter styling? |
The logo is already in the docs so we can probably close. I'm still a bit confused as to what "Benchmarks.jl" stands for in the social media preview though, isn't it a little misleading regarding the actual name of the package? |
Oops - I completely overlooked that mistake ... 😱 I'll redo it tomorrow if that's OK... |
@cormullion, casually renaming core packages since 2023 |
haha - well it really should be Benchmarks, but it superseded an older package with that name already taken, hence the Tools. The rich texture of history ... 😀 |
Honestly that's half of the reason why I work so hard to make Graphs.jl succeed, it's cause we finally have the right name 🤣 |
I hope to not see GraphsNext.jl ... |
You just gave me nightmares. But if all goes well you may not even need to see MetaGraphs(Next).jl ever again |
@ararslan here we go ^^ |
Alright, replaced with the updated one 👍 |
@cormullion had a logo suggestion for BenchmarkTools.jl which I kinda like
JuliaLang/www.julialang.org#818 (comment)
thoughts?
The text was updated successfully, but these errors were encountered: