Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only support tuples and not single inputs/outputs #103

Closed
gdalle opened this issue Aug 9, 2023 · 7 comments
Closed

Only support tuples and not single inputs/outputs #103

gdalle opened this issue Aug 9, 2023 · 7 comments

Comments

@gdalle
Copy link
Member

gdalle commented Aug 9, 2023

The ambiguity between tuples and single inputs/outputs in pushforwards and pullbacks is causing several bugs (#99) and making the code more complicated.

I propose to make a breaking change that supports only tuples

cc @devmotion

@devmotion
Copy link
Member

An alternative would be #53

@gdalle
Copy link
Member Author

gdalle commented Aug 9, 2023

Good point. How to decide between the two? Would one be

  • easier to code?
  • more likely to be type-stable?

@gdalle
Copy link
Member Author

gdalle commented Aug 9, 2023

On second thought they're actually the same, replacing args... with args everywhere does the translation

@mohamed82008
Copy link
Member

I think it should be fine to only support tuples. I don't recall why we support both but we can just support one.

@gdalle
Copy link
Member Author

gdalle commented Aug 9, 2023

Only supporting plain inputs / outputs as in #53 sounds slightly more natural though, doesn't it?

@mohamed82008
Copy link
Member

that's also fine by me

@gdalle
Copy link
Member Author

gdalle commented Aug 9, 2023

Closing this in favor of #53 then

@gdalle gdalle closed this as completed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants