Remove CI check for invalidations #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we instead change this to be a soft-fail? IMO, the invalidations table that is printed in the GHA is still useful and provides actionable information. Testing on the single number of invalidations seems very impractical to me. |
|
The action is broken currently: https://github.com/JuliaDiff/ForwardDiff.jl/actions/runs/11857687121/job/33046631013?pr=721 Of course, we could try to fix it, but due to the points mentioned above (no impact, incorrect reports, and arguably conceptually questionable) IMO it would be better to remove it. |
|
Yes, it's worthless. |
KristofferC
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR removes the invalidation check, since it has been failing due to a JET error for a while, is IMO typically ignored, doesn't flag increased numbers of invalidations correctly (julia-actions/julia-invalidations#20) and might be misguided (julia-actions/julia-invalidations#19).