Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up with MutableArithmetics #343

Merged
merged 8 commits into from
Jan 15, 2025
Merged

Speed up with MutableArithmetics #343

merged 8 commits into from
Jan 15, 2025

Conversation

blegat
Copy link
Member

@blegat blegat commented Aug 9, 2024

Before

BenchmarkTools.Trial: 10000 samples with 4 evaluations.
 Range (min … max):   8.011 μs …  40.041 ms  ┊ GC (min … max):  0.00% … 99.93%
 Time  (median):      8.852 μs               ┊ GC (median):     0.00%
 Time  (mean ± σ):   15.422 μs ± 401.401 μs  ┊ GC (mean ± σ):  34.24% ±  4.36%

   ▃▅▇██▇▆▅▄▃▂▂▁▂▁▁▁▁                       ▁▂▃▄▄▄▄▄▃▃▂▂▁▁     ▃
  ▇█████████████████████▇▇█▆▇▅▆▁▅▁▁▄▃▁▁▃▁▃▆▇███████████████▇▇▆ █
  8.01 μs       Histogram: log(frequency) by time      16.6 μs <

 Memory estimate: 31.62 KiB, allocs estimate: 597.

After

BenchmarkTools.Trial: 10000 samples with 7 evaluations.
 Range (min … max):  4.033 μs …  17.567 ms  ┊ GC (min … max):  0.00% … 99.92%
 Time  (median):     4.293 μs               ┊ GC (median):     0.00%
 Time  (mean ± σ):   7.163 μs ± 175.969 μs  ┊ GC (mean ± σ):  30.43% ±  3.89%

  ▁▆██▇▅▃▁▁▁▁▁                           ▁▂▂▃▃▃▄▃▃▃▃▂▁        ▂
  ██████████████▇▆▆▆▆▆▅▅▄▄▂▄▄▅▅▇▇▆▄▃▂▄▆▆███████████████▇▇▇▅▅▅ █
  4.03 μs      Histogram: log(frequency) by time      8.13 μs <

 Memory estimate: 14.02 KiB, allocs estimate: 254.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 88.44221% with 23 lines in your changes missing coverage. Please review.

Project coverage is 88.37%. Comparing base (8c131a6) to head (0350c1d).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/elements.jl 62.06% 11 Missing ⚠️
src/repelemop.jl 76.47% 8 Missing ⚠️
src/comp.jl 88.88% 3 Missing ⚠️
src/incidence.jl 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
- Coverage   88.98%   88.37%   -0.62%     
==========================================
  Files          37       37              
  Lines        3205     3226      +21     
==========================================
- Hits         2852     2851       -1     
- Misses        353      375      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blegat blegat merged commit 1688368 into master Jan 15, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant