From cfd50f466f823ccb4013eb37e81b9e0f4bd2a897 Mon Sep 17 00:00:00 2001 From: Willow Ahrens Date: Wed, 8 Jan 2025 18:23:07 -0500 Subject: [PATCH 1/3] fix windows failure fixes a windows failure due to asserting Int64 when the architecture may be Int32 ``` ERROR: LoadError: TaskFailedException nested task error: LoadError: MethodError: Cannot `convert` an object of type Base.RefValue{Int32} to an object of type Base.RefValue{Int64} Closest candidates are: convert(::Type{T}, ::T) where T @ Base Base.jl:84 Base.RefValue{T}(::Any) where T @ Base refvalue.jl:8 Stacktrace: [1] TestItem(number::Base.RefValue{Int32}, name::String, id::String, tags::Vector{Symbol}, default_imports::Bool, setups::Vector{Any}, retries::Int32, timeout::Nothing, skip::Bool, failfast::Nothing, file::String, line::Int32, project_root::String, code::Expr, testsetups::Vector{TestSetup}, workerid::Base.RefValue{Int32}, testsets::Vector{Test.DefaultTestSet}, eval_number::Base.RefValue{Int32}, stats::Vector{ReTestItems.PerfStats}, scheduled_for_evaluation::ReTestItems.ScheduledForEvaluation) ``` --- src/macros.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/macros.jl b/src/macros.jl index fdaeb925..d992e565 100644 --- a/src/macros.jl +++ b/src/macros.jl @@ -112,7 +112,7 @@ those test in their own module. Should only be created via the `@testitem` macro. """ struct TestItem - number::Base.RefValue{Int64} # populated by runtests coordinator once all test items are known + number::Base.RefValue{Int} # populated by runtests coordinator once all test items are known name::String id::String # in case file/name isn't a sufficiently stable identifier for reporting purposes tags::Vector{Symbol} From 627c584ec6e9a2ff3075df70757086f4b8397954 Mon Sep 17 00:00:00 2001 From: Willow Ahrens Date: Wed, 8 Jan 2025 18:36:03 -0500 Subject: [PATCH 2/3] Update CI.yml --- .github/workflows/CI.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 1aee326b..715c6753 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -23,8 +23,17 @@ jobs: os: - ubuntu-latest - macOS-latest + - windows-latest arch: - x64 + - x86 + exclude: + - os: macOS-latest + arch: x86 + - os: ubuntu-latest + arch: x86 + - os: windows-latest + arch: x64 steps: - uses: actions/checkout@v3.5.0 - uses: julia-actions/setup-julia@v1 From 69bdc6905a331c91256709c9549637c75c06a3d1 Mon Sep 17 00:00:00 2001 From: Willow Ahrens Date: Wed, 8 Jan 2025 18:39:25 -0500 Subject: [PATCH 3/3] Update CI.yml --- .github/workflows/CI.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 715c6753..ee016700 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -34,6 +34,10 @@ jobs: arch: x86 - os: windows-latest arch: x64 + - os: windows-latest + version: 1.8 + - os: windows-latest + version: 1.11 steps: - uses: actions/checkout@v3.5.0 - uses: julia-actions/setup-julia@v1