Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon pack support #2

Open
4 of 6 tasks
Donnnno opened this issue Jul 31, 2024 · 21 comments
Open
4 of 6 tasks

Icon pack support #2

Donnnno opened this issue Jul 31, 2024 · 21 comments

Comments

@Donnnno
Copy link

Donnnno commented Jul 31, 2024

As the title says! Support for icon packs like other launchers :)

Just stumbled on your launcher through F-Droid, and it has lots of potential.

A few things that are nice to haves:

  • PNG, webp & XML support
  • Material You
  • day night switching
  • dynamic calendar icons
  • dynamic clock icons
  • picking custom icons

Nova & Kvaesitso launcher both have good documentation for these things:

https://github.com/teslacoil/Example_NovaTheme/blob/master/DynamicCalendarIconAPI.md

https://kvaesitso.mm20.de/docs/developer-guide/integrations/icon-packs.html

PS. I'm an icon pack developer myself, so I'm a bit biased when it comes to this stuff ;)

@JunioJsv
Copy link
Owner

Great suggestions, I was already researching how I could implement support for icon packs

@JunioJsv
Copy link
Owner

In terms of material you, you are referring to those monochromatic icons, right?

@Donnnno
Copy link
Author

Donnnno commented Jul 31, 2024

Oh great!
Material You are the monochromatic icons, yea.

There are many icon packs that utilize this feature:

https://help.niagaralauncher.app/article/150-list-of-android-material-you-icon-packs

However do some launchers lack the support, unfortunately.

https://docs.arcticons.com/faq/supported-launchers

@JunioJsv
Copy link
Owner

JunioJsv commented Aug 2, 2024

Hello, I just released a version with support for icon packs (com.gau.go.launcherex.theme, org.adw.launcher.THEMES). Since you mentioned that you are an icon pack developer, could you test it and send me feedback? The implementation is still basic, but I think it works with most packs.

@Donnnno
Copy link
Author

Donnnno commented Aug 2, 2024

Fantastic, I'll test it immediately :)

@Donnnno
Copy link
Author

Donnnno commented Aug 2, 2024

Super! It does work.
In my quick tests I found the following issues however:

  • It doesn't update every icon, despite being mapped in the icon pack.
  • Currently it doesn't check if you've changed your system preference to dark or light, resulting in not refreshing the icons' dark or light variant.

Screenshot_20240802_170008.png

Screenshot_20240802_170033.png

@JunioJsv
Copy link
Owner

JunioJsv commented Aug 2, 2024

I just uploaded a new version with the fix for the problem of not updating icons when switching from light to dark theme and vice versa.

@JunioJsv
Copy link
Owner

JunioJsv commented Aug 2, 2024

the other problem you reported, I will still investigate

@Donnnno
Copy link
Author

Donnnno commented Aug 2, 2024

The switching works like a charm now!

I'll investigate which apps have trouble with applying later.

And also while I'm at it, maybe an option to disable the drop shadow thingy might be nice too :-)

I'm adding Minimum to the supported launcher list with full support!

@Donnnno
Copy link
Author

Donnnno commented Aug 2, 2024

Update: it looks like those apps are system apps that are hidden by default on most launches. So it's not necessarily a launcher thing.

@JunioJsv
Copy link
Owner

JunioJsv commented Aug 2, 2024

Update: it looks like those apps are system apps that are hidden by default on most launches. So it's not necessarily a launcher thing.

I don't understand, what do you mean?

@JunioJsv
Copy link
Owner

JunioJsv commented Aug 2, 2024

Update: it looks like those apps are system apps that are hidden by default on most launches. So it's not necessarily a launcher thing.

I understand, it was actually displaying some system applications without the android.intent.category.LAUNCHER category, I will hide this type of application

@JunioJsv
Copy link
Owner

JunioJsv commented Aug 2, 2024

ready, in this version only applications with android.intent.category.LAUNCHER will be displayed

@Donnnno
Copy link
Author

Donnnno commented Aug 2, 2024

Nice! That fixed it :))

@mondlicht-und-sterne
Copy link

I am also an Icon Pack developer and would be delighted to receive it.

@mondlicht-und-sterne
Copy link

It works.

Mondstern Acrylic Icons.

IMG_20240803_160217_851

@JunioJsv
Copy link
Owner

JunioJsv commented Aug 7, 2024

Hello, I just posted a new version with the functionality to choose custom icons

@Donnnno
Copy link
Author

Donnnno commented Aug 7, 2024

Works great too!

@mondlicht-und-sterne
Copy link

For me, the latest version just loads and loads and loads.

Samsung S21 5G,
Android 14
IMG_20240808_052719_763

@JunioJsv
Copy link
Owner

JunioJsv commented Aug 8, 2024

@mondlicht-und-sterne Have you tried clearing the app data? I'll need to collect the errors somehow to be able to resolve this.

@JunioJsv
Copy link
Owner

JunioJsv commented Aug 8, 2024

@mondlicht-und-sterne test with this new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants