Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Improvments #5

Open
mkg20001 opened this issue Aug 27, 2019 · 3 comments
Open

[Discussion] Improvments #5

mkg20001 opened this issue Aug 27, 2019 · 3 comments

Comments

@mkg20001
Copy link

I noticed the following:

  • A package-lock.json is in the repo. Is this wanted?
  • A webpack based bundler is used. Can we switch to parcel to increase the build speed?
  • No linting is being used. Can the aegir linting style be used?
  • React is being used. I don't know if vue is faster. This might be good to switch if it's true.
@JustMaier
Copy link
Owner

  • We should remove the package-lock
  • Webpack is fine as the bundler for now. It's the default create-react-app bundler (with a minor change to support HMR)
  • Pretty sure Aegir uses standard and this is using standard, we just don't have any forced linting atm
  • Not sure if Vue is faster either, but I don't believe it makes sense to rework the entire app at this time.

Things I'd like to see improved for now:

  • Replace OrbitDB with a lighter/faster Op Log CRDT (hopefully, the one we're working on)
  • Add an introduction to the landing page, so that first-time users can understand how it works

@vrortvedt can you think of any improvements you'd like to see

@vrortvedt
Copy link
Collaborator

Agree with your suggested improvements @JustMaier.

Should we also implement the following features?

  • Delete the autofilling of codename info in the name field in the onboarding profile page and require that name info be added before leaving the page

  • Permit the app to pull some of the user's locally saved personal contact info into certain profile fields (name, email, profile pic, city of address, etc)

  • We should also think about how to handle consecutive gatherings. Can/should we build it such that if a user joins a new gathering that his or her previous connections have also joined, the app can automagically add those connections in the new gathering? This could be useful in a) continuing to build relationships with prior connections and b) recommending matches. I could also imagine that failure to include this option might limit the utility of the app, as users would have to start from scratch at each gathering.

@mkg20001
Copy link
Author

Replace OrbitDB with a lighter/faster Op Log CRDT (hopefully, the one we're working on)

I'm trying to make it fit exactly for gathering, so it won't be as general-purpose as expected, but it should be pretty performant. The unfinished version can be found at https://github.com/mkg20001/crdt-event-log-lite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants