-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup continuous deployments (releases + ghcr.io docker image) #59
Comments
@ll-nick FYI |
And let's run the unit tests too |
I just added a workflow for executing the unit tests, see #61 To make sure it actually fails if a test fails, I pushed a broken commit (but fixed it again after 😝 ), see the workflows. So far, that only covers the unit tests of the core library. Testing the demo unit tests only makes sense after we merged them to main (same goes for the docker deployment which is also done for the core library already). |
Oh and for the tar releases, we probably need some versioning system right? Or do we simply deploy a dev release using the main branch? |
I'll setup a semantic versioning for that and the docker images as well. Let's continue working with a main and feature branches (gitflow is too much overhead for a small repo like this) and auto-deploy a release on every merge to main. The version will be written to a |
Alright, so I thought about the versioning. Now, there's a ton of tools to ease semantic versioning, releases etc. (most overkill). The latter is quite nice, it checks the commit log for bumping commands ( |
That sounds good. I like the version bump on merge to main. Sounds like little overhead and I think anything more than that is probably going to be overkill for what we do here 👍 |
@orzechow Do we want to release docker images for the demo on ghcr as well? |
Ah nevermind, I missed it in the todo list above. I'll add that to the workflow too. |
Why not? 😁 Users would still need the compose file though for X11 settings etc. (or we provide a docker run command with all these settings) |
I just added that workflow to #61
You're right but then we are basically better of with docker compose. We could just change the service and remove the And come to think of it, to keep things consistent, we could release the tutorial docker image too and also remove the |
Completed with #61 🎉 |
@ll-nick FYI: our current approach with bumping the version after PR merge, can fail when merging multiple PRs in a short period (as I did with #91, #93, #94 and #95). It's a rare edge case, but doesn't feel great… |
Yes, I'm aware of that. I purposefully merged stuff one at a time in the past but of course that's not the nicest solution. GitHub actually has a setting for that. We should look into that. At first glance, this seems like it would solve our problem. |
Let's write some GitHub Actions to automatically
main
)latest
tags of docker images on ghcr.ioWe should make sure to also
The text was updated successfully, but these errors were encountered: