Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comparison to behavior trees #106

Merged
merged 4 commits into from
Feb 12, 2025
Merged

Conversation

orzechow
Copy link
Member

@orzechow orzechow commented Feb 11, 2025

This adds a comparison to behavior trees and some minor Readme improvements improving readability.

The comparison is based on our new paper section.

#patch

@orzechow orzechow self-assigned this Feb 11, 2025
@orzechow
Copy link
Member Author

@ll-nick ping – not sure, if you received a notification

@ll-nick
Copy link
Collaborator

ll-nick commented Feb 12, 2025

Nice!

I really like the table view. I also think the readme rendering is just fine :)

@ll-nick
Copy link
Collaborator

ll-nick commented Feb 12, 2025

I'll approve already but obviously you should not forget to remove the other version before merging :)

@orzechow orzechow force-pushed the add_comparison_to_behavior_trees branch from 91fec90 to 79375ca Compare February 12, 2025 12:23
@orzechow orzechow marked this pull request as ready for review February 12, 2025 12:24
@orzechow
Copy link
Member Author

Thanks for the feedback!

I cleaned up, tuned the table a bit more and squashed it into 79375ca

@orzechow
Copy link
Member Author

orzechow commented Feb 12, 2025

Cleaned up the PR description for the release.

For later reference, this was the list vs table approach:

The latter doesn't look that great w.r.t. style on GitHub, but great on GitHub Pages 🤷

@ll-nick Please let me know, which one you prefer and I'll remove the other.

GitHub Readme:

GitHub Pages:

@orzechow orzechow changed the title add comparison to behavior trees Add comparison to behavior trees Feb 12, 2025
@orzechow orzechow merged commit b22f3c8 into main Feb 12, 2025
1 check passed
@orzechow orzechow deleted the add_comparison_to_behavior_trees branch February 12, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants